From: Eric Dumazet <eric.dumazet@gmail.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Eric Dumazet <edumazet@google.com>, netdev@vger.kernel.org
Subject: Re: 3.5 bridging regression
Date: Sun, 21 Oct 2012 15:46:42 +0200 [thread overview]
Message-ID: <1350827202.13333.2284.camel@edumazet-glaptop> (raw)
In-Reply-To: <20121021132610.GG21937@1wt.eu>
On Sun, 2012-10-21 at 15:26 +0200, Willy Tarreau wrote:
> On Sun, Oct 21, 2012 at 01:53:33PM +0200, Eric Dumazet wrote:
> > Hello Willy
> >
> > This is most probably the needed fix.
>
> Good catch, as usual ! It works flawlessly here on top of 3.6.2.
>
> > I guess David planned to send it to stable teams if not already done.
>
> Indeed, I've not seen it there yet.
>
> David, are you OK with sending this patch for -stable ? It fixes
> a 3.5 regression causing bridge to panic.
>
> > commit acb600def2110b1310466c0e485c0d26299898ae
> > Author: Eric Dumazet <edumazet@google.com>
> > Date: Fri Oct 5 06:23:55 2012 +0000
> >
> > net: remove skb recycling
> >
> > Over time, skb recycling infrastructure got litle interest and
> > many bugs. Generic rx path skb allocation is now using page
> > fragments for efficient GRO / TCP coalescing, and recyling
> > a tx skb for rx path is not worth the pain.
>
> Thanks and have a nice week-end !
> Willy
>
Thanks for testing, sorry for adding a bug.
skb_recycle() was losing skb->head_frag status.
(we could have added some logic in skb_is_recycleable(), but this
function was becoming really too complex)
next prev parent reply other threads:[~2012-10-21 13:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-21 11:27 3.5 bridging regression Willy Tarreau
2012-10-21 11:53 ` Eric Dumazet
2012-10-21 13:26 ` Willy Tarreau
2012-10-21 13:46 ` Eric Dumazet [this message]
2012-10-21 15:37 ` Willy Tarreau
2012-10-21 23:25 ` David Miller
2012-10-21 23:31 ` Willy Tarreau
2012-10-21 23:38 ` David Miller
2012-10-21 23:54 ` Willy Tarreau
2012-10-21 23:56 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350827202.13333.2284.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox