From: Veaceslav Falico <vfalico@redhat.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, richardcochran@gmail.com,
tshimizu818@gmail.com, andy.cress@us.kontron.com,
erwan.velu@zodiacaerospace.com, agospoda@redhat.com
Subject: [PATCH 0/3] pch_gbe: fix CRC errors and improve speed
Date: Mon, 22 Oct 2012 16:43:22 +0200 [thread overview]
Message-ID: <1350917005-26350-1-git-send-email-vfalico@redhat.com> (raw)
This patch series tries to get rid of CRC errors and other instability
caused by wrong RX_FIFO overrun processing. It also cleans the code a bit.
Now (without the patch applied) on high number of incoming packets and/or
stressed system pch_gbe driver reports CRC errors and huge numbers of
RX_FIFO_ERR (overruns). It also sometimes just freezes (caused by not
waiting enough on DMA_RX to stop before issuing a reset on MAC_RX logic).
This patchset removes the unneeded (as per datasheet) MAC_RX reset and
corrects the processing of RX_FIFO_ERR in pch_gbe_napi_poll().
With the patchset applied there are no more CRC errors, sane number of
RX_FIFO_ERR and improved speed/stability. The patchset was tested on
Informix SYS940X and Kontron Tunnel Creek EG20T on 1gbps direct-connected
link and different rx/tx descriptors count.
.../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 99 +++++--------------
1 files changed, 26 insertions(+), 73 deletions(-)
next reply other threads:[~2012-10-22 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 14:43 Veaceslav Falico [this message]
2012-10-22 14:43 ` [PATCH 1/3] pch_gbe: create functions for MAC_RX {en,dis}able Veaceslav Falico
2012-10-22 14:43 ` [PATCH 2/3] pch_gbe: don't re-set RX_FIFO_ERR flag in napi_poll Veaceslav Falico
2012-10-22 14:43 ` [PATCH 3/3] pch_gbe: don't reset MAC_RX on FIFO overflow Veaceslav Falico
2012-10-23 6:31 ` [PATCH 0/3] pch_gbe: fix CRC errors and improve speed David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350917005-26350-1-git-send-email-vfalico@redhat.com \
--to=vfalico@redhat.com \
--cc=agospoda@redhat.com \
--cc=andy.cress@us.kontron.com \
--cc=davem@davemloft.net \
--cc=erwan.velu@zodiacaerospace.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tshimizu818@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).