From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [net-next 08/12] ixgbe: using is_zero_ether_addr() to simplify the code Date: Mon, 22 Oct 2012 21:45:18 -0700 Message-ID: <1350967518.7502.32.camel@joe-AO722> References: <1350966385-19020-1-git-send-email-jeffrey.t.kirsher@intel.com> <1350966385-19020-9-git-send-email-jeffrey.t.kirsher@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, Wei Yongjun , netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com To: Jeff Kirsher Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:34921 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750885Ab2JWEpT (ORCPT ); Tue, 23 Oct 2012 00:45:19 -0400 In-Reply-To: <1350966385-19020-9-git-send-email-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2012-10-22 at 21:26 -0700, Jeff Kirsher wrote: > From: Wei Yongjun > Using is_zero_ether_addr() to simplify the code. [] > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c [] > @@ -1778,8 +1778,7 @@ s32 ixgbe_validate_mac_addr(u8 *mac_addr) [] > - else if (mac_addr[0] == 0 && mac_addr[1] == 0 && mac_addr[2] == 0 && > - mac_addr[3] == 0 && mac_addr[4] == 0 && mac_addr[5] == 0) > + else if (is_zero_ether_addr(mac_addr)) This means the more comprehensive simplifying patch I submitted doesn't apply. Easy to fix up though.