From: Joe Perches <joe@perches.com>
To: jeffrey.t.kirsher@intel.com
Cc: davem@davemloft.net, Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 08/12] ixgbe: using is_zero_ether_addr() to simplify the code
Date: Tue, 23 Oct 2012 12:35:47 -0700 [thread overview]
Message-ID: <1351020947.7502.51.camel@joe-AO722> (raw)
In-Reply-To: <1350969467.2135.11.camel@jtkirshe-mobl>
On Mon, 2012-10-22 at 22:17 -0700, Jeff Kirsher wrote:
> On Mon, 2012-10-22 at 21:45 -0700, Joe Perches wrote:
> > On Mon, 2012-10-22 at 21:26 -0700, Jeff Kirsher wrote:
> > > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > > Using is_zero_ether_addr() to simplify the code.
> > []
> > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
> > []
> > > @@ -1778,8 +1778,7 @@ s32 ixgbe_validate_mac_addr(u8 *mac_addr)
> > []
> > > - else if (mac_addr[0] == 0 && mac_addr[1] == 0 && mac_addr[2] == 0 &&
> > > - mac_addr[3] == 0 && mac_addr[4] == 0 && mac_addr[5] == 0)
> > > + else if (is_zero_ether_addr(mac_addr))
> >
> > This means the more comprehensive simplifying patch
> > I submitted doesn't apply. Easy to fix up though.
> >
[]
> Want me to
> send you the fixed up patch so that you can confirm my fixes?
Nope, no worries, I'm sure you'll do the right thing.
I just wanted to alert you about it.
next prev parent reply other threads:[~2012-10-23 19:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 4:26 [net-next 00/12][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-10-23 4:26 ` [net-next 01/12] ixgbe: Add support for IPv6 and UDP to ixgbe_get_headlen Jeff Kirsher
2012-10-23 4:26 ` [net-next 02/12] ixgbe: Add support for tracking the default user priority to SR-IOV Jeff Kirsher
2012-10-23 4:26 ` [net-next 03/12] ixgbe: Add support for GET_QUEUES message to get DCB configuration Jeff Kirsher
2012-10-23 4:26 ` [net-next 04/12] ixgbe: Enable support for VF API version 1.1 in the PF Jeff Kirsher
2012-10-23 4:26 ` [net-next 05/12] ixgbevf: Add VF DCB + SR-IOV support Jeff Kirsher
2012-10-23 4:26 ` [net-next 06/12] ixgbe: add WOL support for new subdevice id Jeff Kirsher
2012-10-23 4:26 ` [net-next 07/12] ixgbe: (PTP) refactor init, cyclecounter and reset Jeff Kirsher
2012-10-23 4:26 ` [net-next 08/12] ixgbe: using is_zero_ether_addr() to simplify the code Jeff Kirsher
2012-10-23 4:45 ` Joe Perches
2012-10-23 5:17 ` Jeff Kirsher
2012-10-23 19:35 ` Joe Perches [this message]
2012-10-23 4:26 ` [net-next 09/12] ixgbe: Correcting small packet padding Jeff Kirsher
2012-10-23 4:26 ` [net-next 10/12] ixgbe: Drop unnecessary addition from ixgbe_set_rx_buffer_len Jeff Kirsher
2012-10-23 4:26 ` [net-next 11/12] ixgbe: Add function ixgbe_reset_pipeline_82599 Jeff Kirsher
2012-10-23 4:26 ` [net-next 12/12] ixgbe: Fix possible memory leak in ixgbe_set_ringparam Jeff Kirsher
2012-10-23 6:51 ` [net-next 00/12][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351020947.7502.51.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).