From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: netdev@vger.kernel.org
Cc: Wei Yang <Wei.Yang@windriver.com>,
Claudiu Manoil <claudiu.manoil@freescale.com>,
Timur Tabi <timur@freescale.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH] gianfar_ptp: use iomem, not ioports resource tree in probe
Date: Wed, 24 Oct 2012 11:21:36 -0400 [thread overview]
Message-ID: <1351092096-14811-1-git-send-email-paul.gortmaker@windriver.com> (raw)
From: Wei Yang <Wei.Yang@windriver.com>
When using a 36 bit dtb file, the driver complains "resource busy".
Investigating the source of the message leads one to the
gianfar_ptp_probe function.
Since the type of the device resource requested in this function
is IORESOURCE_MEM, it should use "iomem_resource" instead of
"ioports_resource".
Signed-off-by: Wei Yang <Wei.Yang@windriver.com>
Cc: Claudiu Manoil <claudiu.manoil@freescale.com>
Cc: Timur Tabi <timur@freescale.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/net/ethernet/freescale/gianfar_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/gianfar_ptp.c b/drivers/net/ethernet/freescale/gianfar_ptp.c
index b9db0e0..2e5daee 100644
--- a/drivers/net/ethernet/freescale/gianfar_ptp.c
+++ b/drivers/net/ethernet/freescale/gianfar_ptp.c
@@ -478,7 +478,7 @@ static int gianfar_ptp_probe(struct platform_device *dev)
pr_err("no resource\n");
goto no_resource;
}
- if (request_resource(&ioport_resource, etsects->rsrc)) {
+ if (request_resource(&iomem_resource, etsects->rsrc)) {
pr_err("resource busy\n");
goto no_resource;
}
--
1.7.11.1
next reply other threads:[~2012-10-24 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 15:21 Paul Gortmaker [this message]
2012-10-24 17:59 ` [PATCH] gianfar_ptp: use iomem, not ioports resource tree in probe Tabi Timur-B04825
2012-10-24 19:09 ` Paul Gortmaker
2012-10-24 19:12 ` Timur Tabi
2012-10-24 19:42 ` Richard Cochran
2012-10-24 20:11 ` Timur Tabi
2012-10-24 20:50 ` Richard Cochran
2012-10-25 11:41 ` wyang1
2012-10-25 20:08 ` Richard Cochran
2012-10-25 20:17 ` Timur Tabi
2012-10-26 10:32 ` Richard Cochran
2012-10-25 3:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351092096-14811-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=Wei.Yang@windriver.com \
--cc=claudiu.manoil@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).