From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] net: allow configuration of the size of page in __netdev_alloc_frag
Date: Wed, 24 Oct 2012 18:43:20 +0200 [thread overview]
Message-ID: <1351097000.6537.109.camel@edumazet-glaptop> (raw)
In-Reply-To: <1351095739.18035.83.camel@zakaz.uk.xensource.com>
On Wed, 2012-10-24 at 17:22 +0100, Ian Campbell wrote:
> On Wed, 2012-10-24 at 16:21 +0100, Eric Dumazet wrote:
> > If you really have such problems, why locally generated TCP traffic
> > doesnt also have it ?
>
> I think it does. The reason I noticed the original problem was that ssh
> to the machine was virtually (no pun intended) unusable.
>
> > Your patch doesnt touch sk_page_frag_refill(), does it ?
>
> That's right. It doesn't. When is (sk->sk_allocation & __GFP_WAIT) true?
> Is it possible I'm just not hitting that case?
>
I hope not. GFP_KERNEL has __GFP_WAIT.
> Is it possible that this only affects certain traffic patterns (I only
> really tried ssh/scp and ping)? Or perhaps its just that the swiotlb is
> only broken in one corner case and not the other.
Could you try a netperf -t TCP_STREAM ?
Because ssh use small packets, and small TCP packets dont use frags but
skb->head.
You mentioned a 70% drop of performance, but what test have you used
exactly ?
next prev parent reply other threads:[~2012-10-24 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 11:42 [PATCH] net: allow configuration of the size of page in __netdev_alloc_frag Ian Campbell
2012-10-24 12:28 ` Eric Dumazet
2012-10-24 13:16 ` Ian Campbell
2012-10-24 13:30 ` Eric Dumazet
2012-10-24 14:02 ` Ian Campbell
2012-10-24 15:21 ` Eric Dumazet
2012-10-24 16:22 ` Ian Campbell
2012-10-24 16:43 ` Eric Dumazet [this message]
2012-10-30 16:53 ` Konrad Rzeszutek Wilk
2012-10-30 17:23 ` Konrad Rzeszutek Wilk
2012-10-31 11:01 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-10-31 11:19 ` Eric Dumazet
2012-10-24 18:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351097000.6537.109.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=edumazet@google.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox