public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: jeffrey.t.kirsher@intel.com, Andrew Morton <akpm@linux-foundation.org>
Cc: netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1
Date: Wed, 24 Oct 2012 14:26:41 -0700	[thread overview]
Message-ID: <1351114001.7130.5.camel@joe-AO722> (raw)
In-Reply-To: <1351111870.1917.4.camel@jtkirshe-mobl>

On Wed, 2012-10-24 at 13:51 -0700, Jeff Kirsher wrote:
> On Wed, 2012-10-24 at 07:12 -0700, Joe Perches wrote:
> > On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
> > > With the recent commit to checkpatch.pl:
> > > 
> > > commit 058806007450489bb8f457b275e5cb5c946320c1
> > > Author: Joe Perches <joe@perches.com>
> > > Date:   Thu Oct 4 17:13:35 2012 -0700
> > > 
> > >     checkpatch: check networking specific block comment style
> > > 
> > > We are seeing false positive warnings.  Here is an example of the
> > > code the would generate a false warning:
> > > 
> > > #define foo	0x0000 /* foo comment */
> > > 
> > > checkpatch.pl generates a warnings that the */ should be on a separate
> > > line, which in this case is incorrect.
> > 
> > Sorry 'bout that.  I believe it's fixed by:
> > https://lkml.org/lkml/2012/10/14/267
> > 
> 
> Yes, I confirm that the patch in the link you provided solves the issue
> I was seeing.  Thanks, has the patch been accepted yet?  I see it is not
> in Dave's NET tree as of yet.

Andrew Morton generally picks up my checkpatch twiddles.
It's in -next as of next-20121024.

commit db64ad0e6f55197bc3794bef007a25f2db4760fb

      reply	other threads:[~2012-10-24 21:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 11:00 [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1 Jeff Kirsher
2012-10-24 14:12 ` Joe Perches
2012-10-24 20:51   ` Jeff Kirsher
2012-10-24 21:26     ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351114001.7130.5.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox