From: Jing Wang <windsdaemon@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Pavel Emelyanov <xemul@parallels.com>
Cc: netdev@vger.kernel.org, Jing Wang <windsdaemon@gmail.com>
Subject: [PATCH 1/1] af_unix.c: fix the compile warning in unix_bind
Date: Fri, 26 Oct 2012 10:48:47 +0800 [thread overview]
Message-ID: <1351219727-6085-1-git-send-email-windsdaemon@gmail.com> (raw)
Signed-off-by: Jing Wang <windsdaemon@gmail.com>
---
net/unix/af_unix.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 5b5c876..3f7d9d5 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -860,6 +860,8 @@ static int unix_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
unsigned int hash;
struct unix_address *addr;
struct hlist_head *list;
+ struct path path;
+ umode_t mode;
err = -EINVAL;
if (sunaddr->sun_family != AF_UNIX)
@@ -890,11 +892,12 @@ static int unix_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
addr->len = addr_len;
addr->hash = hash ^ sk->sk_type;
atomic_set(&addr->refcnt, 1);
-
+
if (sun_path[0]) {
- struct path path;
- umode_t mode = S_IFSOCK |
+ mode = S_IFSOCK |
(SOCK_INODE(sock)->i_mode & ~current_umask());
+
+ memset(&path, 0, sizeof(path));
err = unix_mknod(sun_path, mode, &path);
if (err) {
if (err == -EEXIST)
--
1.7.5.4
next reply other threads:[~2012-10-26 2:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 2:48 Jing Wang [this message]
2012-10-26 3:16 ` [PATCH 1/1] af_unix.c: fix the compile warning in unix_bind David Miller
2012-10-26 3:24 ` jing wang
2012-10-28 5:54 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351219727-6085-1-git-send-email-windsdaemon@gmail.com \
--to=windsdaemon@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).