From: "Bjørn Mork" <bjorn@mork.no>
To: netdev@vger.kernel.org
Cc: linux-usb@vger.kernel.org, "Oliver Neukum" <oliver@neukum.org>,
"Bjørn Mork" <bjorn@mork.no>
Subject: [PATCH net-next] net: cdc_ncm: error path lock fix
Date: Fri, 26 Oct 2012 09:44:09 +0200 [thread overview]
Message-ID: <1351237449-23643-3-git-send-email-bjorn@mork.no> (raw)
In-Reply-To: <1351237449-23643-1-git-send-email-bjorn@mork.no>
Fixes the sparse warning
drivers/net/usb/cdc_ncm.c:836:9: warning: context imbalance in 'cdc_ncm_txpath_bh' - different lock contexts for basic block
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
drivers/net/usb/cdc_ncm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 682b17a..11370fe 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -842,6 +842,8 @@ static void cdc_ncm_txpath_bh(unsigned long param)
netif_tx_lock_bh(ctx->netdev);
usbnet_start_xmit(NULL, ctx->netdev);
netif_tx_unlock_bh(ctx->netdev);
+ } else {
+ spin_unlock_bh(&ctx->mtx);
}
}
--
1.7.10.4
next prev parent reply other threads:[~2012-10-26 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 7:44 [PATCH net-next] net: sierra: shut up sparse restricted type warnings Bjørn Mork
2012-10-26 7:44 ` Bjørn Mork [this message]
[not found] ` <1351237449-23643-3-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2012-10-28 23:08 ` [PATCH net-next] net: cdc_ncm: error path lock fix David Miller
[not found] ` <1351237449-23643-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2012-10-26 7:44 ` [PATCH net-next] net: cdc_ncm: big endian fix Bjørn Mork
2012-10-28 23:08 ` David Miller
2012-10-26 8:15 ` [PATCH v2 net-next] net: sierra: shut up sparse restricted type warnings Bjørn Mork
2012-10-28 23:09 ` [PATCH " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351237449-23643-3-git-send-email-bjorn@mork.no \
--to=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).