netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net/cadence: depend on HAS_IOMEM
@ 2012-10-27 12:10 Joachim Eastwood
  2012-10-29 14:48 ` Nicolas Ferre
  0 siblings, 1 reply; 2+ messages in thread
From: Joachim Eastwood @ 2012-10-27 12:10 UTC (permalink / raw)
  To: nicolas.ferre, davem, fengguang.wu; +Cc: netdev, Joachim Eastwood

Fixes the following build failure on S390:
  In file included from drivers/net/ethernet/cadence/at91_ether.c:35:0:
   drivers/net/ethernet/cadence/macb.h: In function 'macb_is_gem':
   drivers/net/ethernet/cadence/macb.h:563:2: error: implicit declaration of function '__raw_readl' [-Werror=implicit-function-declaration]
   drivers/net/ethernet/cadence/at91_ether.c: In function 'update_mac_address':
   drivers/net/ethernet/cadence/at91_ether.c:119:2: error: implicit declaration of function '__raw_writel' [-Werror=implicit-function-declaration]
   cc1: some warnings being treated as errors

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
 drivers/net/ethernet/cadence/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
index 40172d1..ceb0de0 100644
--- a/drivers/net/ethernet/cadence/Kconfig
+++ b/drivers/net/ethernet/cadence/Kconfig
@@ -4,6 +4,7 @@
 
 config NET_CADENCE
 	bool "Cadence devices"
+	depends on HAS_IOMEM
 	default y
 	---help---
 	  If you have a network (Ethernet) card belonging to this class, say Y.
-- 
1.8.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net/cadence: depend on HAS_IOMEM
  2012-10-27 12:10 [PATCH net-next] net/cadence: depend on HAS_IOMEM Joachim Eastwood
@ 2012-10-29 14:48 ` Nicolas Ferre
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2012-10-29 14:48 UTC (permalink / raw)
  To: Joachim Eastwood; +Cc: davem, fengguang.wu, netdev

On 10/27/2012 02:10 PM, Joachim Eastwood :
> Fixes the following build failure on S390:
>   In file included from drivers/net/ethernet/cadence/at91_ether.c:35:0:
>    drivers/net/ethernet/cadence/macb.h: In function 'macb_is_gem':
>    drivers/net/ethernet/cadence/macb.h:563:2: error: implicit declaration of function '__raw_readl' [-Werror=implicit-function-declaration]
>    drivers/net/ethernet/cadence/at91_ether.c: In function 'update_mac_address':
>    drivers/net/ethernet/cadence/at91_ether.c:119:2: error: implicit declaration of function '__raw_writel' [-Werror=implicit-function-declaration]
>    cc1: some warnings being treated as errors
> 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
>  drivers/net/ethernet/cadence/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
> index 40172d1..ceb0de0 100644
> --- a/drivers/net/ethernet/cadence/Kconfig
> +++ b/drivers/net/ethernet/cadence/Kconfig
> @@ -4,6 +4,7 @@
>  
>  config NET_CADENCE
>  	bool "Cadence devices"
> +	depends on HAS_IOMEM
>  	default y
>  	---help---
>  	  If you have a network (Ethernet) card belonging to this class, say Y.
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-29 13:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-27 12:10 [PATCH net-next] net/cadence: depend on HAS_IOMEM Joachim Eastwood
2012-10-29 14:48 ` Nicolas Ferre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).