From: Cong Wang <amwang@redhat.com>
To: Paolo Valente <paolo.valente@unimore.it>
Cc: netdev@vger.kernel.org, Stephen Hemminger <shemminger@vyatta.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Fabio Checconi <fchecconi@gmail.com>
Subject: Re: [RFC PATCH net-next] qfq: handle the case that front slot is empty
Date: Sun, 28 Oct 2012 20:45:00 +0800 [thread overview]
Message-ID: <1351428300.15482.2.camel@cr0> (raw)
In-Reply-To: <20121026165115.GA16947@paolo-ThinkPad-W520>
On Fri, 2012-10-26 at 18:51 +0200, Paolo Valente wrote:
> Here is a possible patch. Could you please give me a feedback?
>
> If this patch actually works, there are some issues related to it that I would
> like to point out after your (and/or anyone else's) tests.
With this patch applied, I can't reproduce the crash any more.
And the following messages appear in the log:
[ 430.956400] qfq: increasing class max_pkt_size from 1514 to 26130
[ 430.981887] qfq: increasing class max_pkt_size from 26130 to 31922
[ 431.011844] qfq: increasing class max_pkt_size from 1514 to 2962
[ 431.060129] qfq: increasing class max_pkt_size from 31922 to 46402
[ 431.096241] qfq: increasing class max_pkt_size from 2962 to 4410
[ 431.123689] qfq: increasing class max_pkt_size from 4410 to 18890
[ 431.134624] qfq: increasing class max_pkt_size from 18890 to 20338
[ 431.149573] qfq: increasing class max_pkt_size from 20338 to 39162
[ 431.328157] qfq: increasing class max_pkt_size from 46402 to 56538
[ 431.339731] qfq: increasing class max_pkt_size from 56538 to 65226
[ 431.363699] qfq: increasing class max_pkt_size from 39162 to 44954
[ 431.376303] qfq: increasing class max_pkt_size from 44954 to 46402
[ 431.482082] qfq: increasing class max_pkt_size from 46402 to 62330
[ 431.520339] qfq: increasing class max_pkt_size from 62330 to 65226
next prev parent reply other threads:[~2012-10-28 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 4:15 [RFC PATCH net-next] qfq: handle the case that front slot is empty Cong Wang
2012-10-23 7:09 ` Paolo Valente
2012-10-23 8:53 ` Cong Wang
2012-10-26 7:51 ` Paolo Valente
2012-10-26 8:10 ` Eric Dumazet
2012-10-26 9:32 ` [PATCH net-next] net_sched: more precise pkt_len computation Eric Dumazet
2012-10-26 11:11 ` Eric Dumazet
2013-01-10 22:36 ` [PATCH v2 " Eric Dumazet
2013-01-10 22:58 ` David Miller
2012-10-26 16:51 ` [RFC PATCH net-next] qfq: handle the case that front slot is empty Paolo Valente
2012-10-28 12:45 ` Cong Wang [this message]
2012-10-28 16:07 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351428300.15482.2.camel@cr0 \
--to=amwang@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=fchecconi@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paolo.valente@unimore.it \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).