From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next] ipv6: fix a potential NULL deref
Date: Mon, 29 Oct 2012 08:05:34 +0100 [thread overview]
Message-ID: <1351494334.7394.64.camel@edumazet-glaptop> (raw)
In-Reply-To: <1351493366.8221.2.camel@cr0>
On Mon, 2012-10-29 at 14:49 +0800, Cong Wang wrote:
> On Mon, 2012-10-29 at 07:10 +0100, Eric Dumazet wrote:
> > > - dst_release(&rt->dst);
> > > + if (rt)
> > > + dst_release(&rt->dst);
> > > }
> > >
> >
> > dst_release() is like kfree(), it accepts a NULL argument.
> >
>
> 'rt->dst' already dereferences 'rt', no matter dst_release() accepts
> NULL or not.
>
>
&rt->dst doesnt dereference rt, you are quite mistaken.
if rt is NULL, &rt->dst is also NULL
next prev parent reply other threads:[~2012-10-29 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 3:50 [Patch net-next] ipv6: fix a potential NULL deref Cong Wang
2012-10-29 6:10 ` Eric Dumazet
2012-10-29 6:49 ` Cong Wang
2012-10-29 7:05 ` Eric Dumazet [this message]
2012-10-29 7:25 ` Cong Wang
2012-10-29 8:25 ` Eric Dumazet
2012-10-29 17:29 ` David Miller
2012-10-30 1:44 ` Cong Wang
2012-10-29 17:22 ` David Miller
2012-10-29 8:16 ` [Patch net-next] ipv6: remove another useless NULL check Cong Wang
2012-10-29 8:33 ` Eric Dumazet
2012-10-29 9:08 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351494334.7394.64.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox