From: Cong Wang <amwang@redhat.com>
To: netdev@vger.kernel.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Cong Wang <amwang@redhat.com>
Subject: [Patch net-next] ipv6: remove another useless NULL check
Date: Mon, 29 Oct 2012 16:16:25 +0800 [thread overview]
Message-ID: <1351498585-20087-1-git-send-email-amwang@redhat.com> (raw)
In-Reply-To: <1351491005.7394.7.camel@edumazet-glaptop>
When 'rt' is NULL, '&rt->dst' is NULL too because >dst
is always the first field of 'rt'. And dst_release accepts
NULL.
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8f0b12a..adeb479 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2027,8 +2027,7 @@ void addrconf_prefix_rcv(struct net_device *dev, u8 *opt, int len, bool sllao)
addrconf_prefix_route(&pinfo->prefix, pinfo->prefix_len,
dev, expires, flags);
}
- if (rt)
- dst_release(&rt->dst);
+ dst_release(&rt->dst);
}
/* Try to figure out our local address for this prefix */
next prev parent reply other threads:[~2012-10-29 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 3:50 [Patch net-next] ipv6: fix a potential NULL deref Cong Wang
2012-10-29 6:10 ` Eric Dumazet
2012-10-29 6:49 ` Cong Wang
2012-10-29 7:05 ` Eric Dumazet
2012-10-29 7:25 ` Cong Wang
2012-10-29 8:25 ` Eric Dumazet
2012-10-29 17:29 ` David Miller
2012-10-30 1:44 ` Cong Wang
2012-10-29 17:22 ` David Miller
2012-10-29 8:16 ` Cong Wang [this message]
2012-10-29 8:33 ` [Patch net-next] ipv6: remove another useless NULL check Eric Dumazet
2012-10-29 9:08 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351498585-20087-1-git-send-email-amwang@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).