From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaibhav Hiremath Subject: [PATCH 1/4] net: davinci_mdio: Fix typo mistake in calling runtime-pm api Date: Mon, 29 Oct 2012 13:51:18 +0530 Message-ID: <1351498881-32482-3-git-send-email-hvaibhav@ti.com> References: <1351498881-32482-1-git-send-email-hvaibhav@ti.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , Vaibhav Hiremath , Mugunthan V N , Richard Cochran To: Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:50289 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756427Ab2J2IVf (ORCPT ); Mon, 29 Oct 2012 04:21:35 -0400 In-Reply-To: <1351498881-32482-1-git-send-email-hvaibhav@ti.com> Sender: netdev-owner@vger.kernel.org List-ID: By mistake (most likely a copy-paste), instead of pm_runtime_get_sync() api, driver is calling pm_runtime_put_sync() api in resume callback function. The bug was introduced by commit id (ae2c07aaf74: davinci_mdio: runtime PM support). Now, the reason why it didn't impact functionality is, the patch has been tested on AM335x-EVM and BeagleBone platform while submitting; and in case of AM335x the MDIO driver doesn't control the module enable/disable part, which is handled by CPSW driver. Signed-off-by: Vaibhav Hiremath Cc: Mugunthan V N Cc: Richard Cochran --- drivers/net/ethernet/ti/davinci_mdio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c index 51a96db..ae74280 100644 --- a/drivers/net/ethernet/ti/davinci_mdio.c +++ b/drivers/net/ethernet/ti/davinci_mdio.c @@ -465,7 +465,7 @@ static int davinci_mdio_resume(struct device *dev) u32 ctrl; spin_lock(&data->lock); - pm_runtime_put_sync(data->dev); + pm_runtime_get_sync(data->dev); /* restart the scan state machine */ ctrl = __raw_readl(&data->regs->control); -- 1.7.0.4