From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [Patch net-next] ipv6: fix a potential NULL deref
Date: Tue, 30 Oct 2012 09:44:10 +0800 [thread overview]
Message-ID: <1351561450.3556.0.camel@cr0> (raw)
In-Reply-To: <20121029.132936.191100167150004535.davem@davemloft.net>
On Mon, 2012-10-29 at 13:29 -0400, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Mon, 29 Oct 2012 15:25:23 +0800
>
> > But this will be a problem if someone moved dst inside rt, as there
> > is no comment saying dst has to be the first one?
>
> If we move the initial dst member, many things that depend upon it
> being first will have to change.
>
> Your change was unnecessary and inappropriate, and let's just leave
> it at that.
Yeah, that is why I sent:
http://marc.info/?l=linux-netdev&m=135150561014916&w=2
:)
next prev parent reply other threads:[~2012-10-30 1:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 3:50 [Patch net-next] ipv6: fix a potential NULL deref Cong Wang
2012-10-29 6:10 ` Eric Dumazet
2012-10-29 6:49 ` Cong Wang
2012-10-29 7:05 ` Eric Dumazet
2012-10-29 7:25 ` Cong Wang
2012-10-29 8:25 ` Eric Dumazet
2012-10-29 17:29 ` David Miller
2012-10-30 1:44 ` Cong Wang [this message]
2012-10-29 17:22 ` David Miller
2012-10-29 8:16 ` [Patch net-next] ipv6: remove another useless NULL check Cong Wang
2012-10-29 8:33 ` Eric Dumazet
2012-10-29 9:08 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351561450.3556.0.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).