netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Greg Rose <gregory.v.rose@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 02/13] ixgbe: Fix return value from macvlan filter function
Date: Tue, 30 Oct 2012 00:04:19 -0700	[thread overview]
Message-ID: <1351580670-8292-3-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1351580670-8292-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Greg Rose <gregory.v.rose@intel.com>

The function to set the macvlan filter should return success or failure
instead of the index of the filter.  The message processing function was
misinterpreting the index as a non-zero return code indicating failure and
NACKing MAC filter set messages that actually succeeded.

Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 96876b7..8bdb341 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -742,7 +742,8 @@ static int ixgbe_set_vf_macvlan_msg(struct ixgbe_adapter *adapter,
 		e_warn(drv,
 		       "VF %d has requested a MACVLAN filter but there is no space for it\n",
 		       vf);
-	return err;
+
+	return err < 0;
 }
 
 static int ixgbe_negotiate_vf_api(struct ixgbe_adapter *adapter,
-- 
1.7.11.7

  parent reply	other threads:[~2012-10-30  7:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30  7:04 [net-next 00/13][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-10-30  7:04 ` [net-next 01/13] ixgbe: Add support for pipeline reset Jeff Kirsher
2012-10-30  7:04 ` Jeff Kirsher [this message]
2012-10-30  7:04 ` [net-next 03/13] net, ixgbe: handle link local multicast addresses in SR-IOV mode Jeff Kirsher
2012-10-30  7:04 ` [net-next 04/13] ixgbe: clean up the condition for turning on/off the laser Jeff Kirsher
2012-10-30  7:04 ` [net-next 05/13] ixgbe: Return success or failure on VF MAC filter set Jeff Kirsher
2012-10-30  7:04 ` [net-next 06/13] ixgbe: Do not decrement budget in ixgbe_clean_rx_irq Jeff Kirsher
2012-10-30  7:04 ` [net-next 07/13] ixgbe: add/update descriptor maps in comments Jeff Kirsher
2012-10-30  7:04 ` [net-next 08/13] ixgbe: reduce PTP rx path overhead Jeff Kirsher
2012-10-30  7:04 ` [net-next 09/13] ixgbevf: Do not forward LLDP type frames Jeff Kirsher
2012-10-30  7:04 ` [net-next 10/13] igbvf: Check for error on dma_map_single call Jeff Kirsher
2012-10-30  7:04 ` [net-next 11/13] igb: Enable auto-crossover during forced operation on 82580 and above Jeff Kirsher
2012-10-30  7:04 ` [net-next 12/13] igb: Update firmware version info for ethtool output Jeff Kirsher
2012-10-30  7:04 ` [net-next 13/13] igb: Fix sparse warning in igb_ptp_rx_pktstamp Jeff Kirsher
2012-10-31 18:28 ` [net-next 00/13][pull request] Intel Wired LAN Driver Updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351580670-8292-3-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=gregory.v.rose@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).