From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: [PATCH v2 RESEND 4/6] net: calxedaxgmac: drop some unnecessary register writes Date: Thu, 1 Nov 2012 05:41:02 -0500 Message-ID: <1351766464-27354-5-git-send-email-robherring2@gmail.com> References: <1351766464-27354-1-git-send-email-robherring2@gmail.com> Cc: eric.dumazet@gmail.com, Rob Herring To: netdev@vger.kernel.org, davem@davemloft.net Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:64228 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755802Ab2KAKlY (ORCPT ); Thu, 1 Nov 2012 06:41:24 -0400 Received: by mail-bk0-f46.google.com with SMTP id jk13so1000955bkc.19 for ; Thu, 01 Nov 2012 03:41:24 -0700 (PDT) In-Reply-To: <1351766464-27354-1-git-send-email-robherring2@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Rob Herring The interrupts have already been cleared, so we don't need to clear them again. Also, we could miss interrupts if they are cleared, but we don't process the packet. Signed-off-by: Rob Herring --- drivers/net/ethernet/calxeda/xgmac.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index 117839e..4a1a06a 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c @@ -846,9 +846,6 @@ static void xgmac_free_dma_desc_rings(struct xgmac_priv *priv) static void xgmac_tx_complete(struct xgmac_priv *priv) { int i; - void __iomem *ioaddr = priv->base; - - writel(DMA_STATUS_TU | DMA_STATUS_NIS, ioaddr + XGMAC_DMA_STATUS); while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) { unsigned int entry = priv->tx_tail; @@ -1139,9 +1136,6 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit) struct sk_buff *skb; int frame_len; - writel(DMA_STATUS_RI | DMA_STATUS_NIS, - priv->base + XGMAC_DMA_STATUS); - entry = priv->rx_tail; p = priv->dma_rx + entry; if (desc_get_owner(p)) -- 1.7.10.4