From: Ming Lei <ming.lei@canonical.com>
To: "David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Oliver Neukum <oneukum@suse.de>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH v1 0/5] usbnet: avoiding access auto-suspended device
Date: Sun, 4 Nov 2012 09:29:49 +0800 [thread overview]
Message-ID: <1351992594-12818-1-git-send-email-ming.lei@canonical.com> (raw)
Thip patchset avoids accessing auto-suspended device in ioctl path,
which is generally triggered by some network utility(ethtool, ifconfig,
...)
Most of network devices have the problem, but as discussed in the
thread:
http://marc.info/?t=135054860600003&r=1&w=2
the problem should be solved inside driver.
Considered that only smsc75xx and smsc95xx calls usbnet_read_cmd()
and usbnet_write_cmd() inside its resume and suspend callback, the
patcheset introduce the nopm version of the two functions which
should be called only in the resume and suspend callback. So we
can solve the problem by runtime resuming device before doing
control message things.
The patchset is against 3.7.0-rc3-next-20121102, and has been tested
OK on smsc95xx usbnet device.
Change logs:
V1:
- rebased on 3.7.0-rc3-next-20121102, only patch 4/5 changed
- fix one memory leak during smsc95xx_suspend, patch 3/5 added
drivers/net/usb/smsc75xx.c | 133 +++++++++++++++++++++++++---------------
drivers/net/usb/smsc95xx.c | 146 ++++++++++++++++++++++++++++----------------
drivers/net/usb/usbnet.c | 72 ++++++++++++++++++++--
include/linux/usb/usbnet.h | 4 ++
4 files changed, 248 insertions(+), 107 deletions(-)
Thanks,
--
Ming Lei
next reply other threads:[~2012-11-04 1:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 1:29 Ming Lei [this message]
2012-11-04 1:29 ` [PATCH v1 1/5] usbnet: introduce usbnet_read[write]_cmd_nopm Ming Lei
2012-11-04 1:29 ` [PATCH v1 2/5] usbnet: smsc75xx: apply the introduced usbnet_read[write]_cmd_nopm Ming Lei
2012-11-04 5:58 ` David Miller
2012-11-04 11:19 ` Ming Lei
[not found] ` <1351992594-12818-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2012-11-04 1:29 ` [PATCH v1 3/5] usbnet: smsc95xx: fix memory leak in smsc95xx_suspend Ming Lei
2012-11-04 1:29 ` [PATCH v1 4/5] usbnet: smsc95xx: apply the introduced usbnet_read[write]_cmd_nopm Ming Lei
2012-11-04 1:29 ` [PATCH v1 5/5] usbnet: make device out of suspend before calling usbnet_read[write]_cmd Ming Lei
2012-11-05 9:24 ` [PATCH v1 0/5] usbnet: avoiding access auto-suspended device Oliver Neukum
[not found] ` <9016904.gHGBncEQ14-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-11-05 16:50 ` David Miller
[not found] ` <20121105.115010.1531838246984342873.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-11-06 1:49 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351992594-12818-1-git-send-email-ming.lei@canonical.com \
--to=ming.lei@canonical.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).