netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: eric.dumazet@gmail.com, Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH v3 4/6] net: calxedaxgmac: drop some unnecessary register writes
Date: Mon,  5 Nov 2012 10:22:22 -0600	[thread overview]
Message-ID: <1352132544-15809-5-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1352132544-15809-1-git-send-email-robherring2@gmail.com>

From: Rob Herring <rob.herring@calxeda.com>

The interrupts have already been cleared, so we don't need to clear them
again. Also, we could miss interrupts if they are cleared, but we don't
process the packet.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
 drivers/net/ethernet/calxeda/xgmac.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index 84cd40e..8263219 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -846,9 +846,6 @@ static void xgmac_free_dma_desc_rings(struct xgmac_priv *priv)
 static void xgmac_tx_complete(struct xgmac_priv *priv)
 {
 	int i;
-	void __iomem *ioaddr = priv->base;
-
-	writel(DMA_STATUS_TU | DMA_STATUS_NIS, ioaddr + XGMAC_DMA_STATUS);
 
 	while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) {
 		unsigned int entry = priv->tx_tail;
@@ -1139,9 +1136,6 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit)
 		struct sk_buff *skb;
 		int frame_len;
 
-		writel(DMA_STATUS_RI | DMA_STATUS_NIS,
-		       priv->base + XGMAC_DMA_STATUS);
-
 		entry = priv->rx_tail;
 		p = priv->dma_rx + entry;
 		if (desc_get_owner(p))
-- 
1.7.10.4

  parent reply	other threads:[~2012-11-05 16:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05 16:22 [PATCH v3 0/6] Calxeda xgmac performance fixes Rob Herring
2012-11-05 16:22 ` [PATCH v3 1/6] net: calxedaxgmac: enable operate on 2nd frame mode Rob Herring
2012-11-05 16:22 ` [PATCH v3 2/6] net: calxedaxgmac: remove explicit rx dma buffer polling Rob Herring
2012-11-05 16:22 ` [PATCH v3 3/6] net: calxedaxgmac: use raw i/o accessors in rx and tx paths Rob Herring
2012-11-05 16:22 ` Rob Herring [this message]
2012-11-05 16:22 ` [PATCH v3 5/6] net: calxedaxgmac: rework transmit ring handling Rob Herring
2012-11-06 23:57   ` David Miller
2012-11-07  0:29     ` Rob Herring
2012-11-07  1:10       ` David Miller
2012-11-05 16:22 ` [PATCH v3 6/6] net: calxedaxgmac: ip align receive buffers Rob Herring
2012-11-05 16:53   ` Eric Dumazet
2012-11-07  8:52 ` [PATCH v3 0/6] Calxeda xgmac performance fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352132544-15809-5-git-send-email-robherring2@gmail.com \
    --to=robherring2@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).