From: Eric Dumazet <eric.dumazet@gmail.com>
To: Rob Herring <robherring2@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH v3 6/6] net: calxedaxgmac: ip align receive buffers
Date: Mon, 05 Nov 2012 08:53:37 -0800 [thread overview]
Message-ID: <1352134417.2747.0.camel@edumazet-glaptop> (raw)
In-Reply-To: <1352132544-15809-7-git-send-email-robherring2@gmail.com>
On Mon, 2012-11-05 at 10:22 -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> On gcc 4.7, we will get alignment traps in the ip stack if we don't align
> the ip headers on receive. The h/w can support this, so use ip aligned
> allocations.
>
> Cut down the unnecessary padding on the allocation. The buffer can start on
> any byte alignment, but the size including the begining offset must be 8
> byte aligned. So the h/w buffer size must include the NET_IP_ALIGN offset.
>
> Thanks to Eric Dumazet for the initial patch highlighting the padding issues.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2012-11-05 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 16:22 [PATCH v3 0/6] Calxeda xgmac performance fixes Rob Herring
2012-11-05 16:22 ` [PATCH v3 1/6] net: calxedaxgmac: enable operate on 2nd frame mode Rob Herring
2012-11-05 16:22 ` [PATCH v3 2/6] net: calxedaxgmac: remove explicit rx dma buffer polling Rob Herring
2012-11-05 16:22 ` [PATCH v3 3/6] net: calxedaxgmac: use raw i/o accessors in rx and tx paths Rob Herring
2012-11-05 16:22 ` [PATCH v3 4/6] net: calxedaxgmac: drop some unnecessary register writes Rob Herring
2012-11-05 16:22 ` [PATCH v3 5/6] net: calxedaxgmac: rework transmit ring handling Rob Herring
2012-11-06 23:57 ` David Miller
2012-11-07 0:29 ` Rob Herring
2012-11-07 1:10 ` David Miller
2012-11-05 16:22 ` [PATCH v3 6/6] net: calxedaxgmac: ip align receive buffers Rob Herring
2012-11-05 16:53 ` Eric Dumazet [this message]
2012-11-07 8:52 ` [PATCH v3 0/6] Calxeda xgmac performance fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352134417.2747.0.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox