From: Eric Dumazet <eric.dumazet@gmail.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: David Miller <davem@davemloft.net>,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
Date: Mon, 05 Nov 2012 17:21:42 -0800 [thread overview]
Message-ID: <1352164902.2747.284.camel@edumazet-glaptop> (raw)
In-Reply-To: <50986442.80009@asianux.com>
On Tue, 2012-11-06 at 09:13 +0800, Chen Gang wrote:
> the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
> in seq_printf, it is not suitable to use %8s for ifp->idev->dev->name.
> so change it to %s, since each line has not been solid any more.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> net/ipv6/addrconf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 8f0b12a..9f728a8 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq,
> void *v)
> static int if6_seq_show(struct seq_file *seq, void *v)
> {
> struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
> - seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
> + seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n",
> &ifp->addr,
> ifp->idev->dev->ifindex,
> ifp->prefix_len,
This is a change in if6_seq_show(), not if6_seq_stop() as mentioned in
patch title.
next prev parent reply other threads:[~2012-11-06 1:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 11:17 [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop Chen Gang
2012-11-06 1:11 ` Chen Gang
2012-11-06 1:42 ` Shan Wei
2012-11-06 1:57 ` Chen Gang
2012-11-06 3:04 ` Chen Gang
2012-11-06 1:13 ` Chen Gang
2012-11-06 1:21 ` Eric Dumazet [this message]
2012-11-06 1:26 ` Chen Gang
2012-11-06 1:29 ` [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_show Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352164902.2747.284.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=gang.chen@asianux.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox