From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>, Vimalkumar <j.vimal@gmail.com>
Subject: Re: [PATCH net-next] htb: fix two bugs
Date: Mon, 05 Nov 2012 18:31:54 -0800 [thread overview]
Message-ID: <1352169114.3140.47.camel@edumazet-glaptop> (raw)
In-Reply-To: <1352149561.2747.37.camel@edumazet-glaptop>
On Mon, 2012-11-05 at 13:06 -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Commit 56b765b79e9 (htb: improved accuracy at high rates)
> introduced two bugs :
>
> 1) one bstats_update() was inadvertently removed from
> htb_dequeue_tree(), breaking statistics/rate estimation.
>
> 2) Missing qdisc_put_rtab() calls in htb_change_class(),
> leaking kernel memory, now struct htb_class no longer
> retains pointers to qdisc_rate_table structs.
>
> Since only rate is used, dont use qdisc_get_rtab() calls
> copying data we ignore anyway.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Vimalkumar <j.vimal@gmail.com>
> ---
Please hold on this patch, I'll add a check in V2 :
We should make sure rates are not zero (check is done in
qdisc_get_rtab())
prev parent reply other threads:[~2012-11-06 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 21:06 [PATCH net-next] htb: fix two bugs Eric Dumazet
2012-11-06 2:31 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352169114.3140.47.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=j.vimal@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox