From: Wang Dongsheng <dongsheng.wang@freescale.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, Wang Dongsheng <dongsheng.wang@freescale.com>
Subject: [PATCH] powerpc/gianfar: fix ethernet cannot work after restoring from hibernation
Date: Tue, 6 Nov 2012 14:04:08 +0800 [thread overview]
Message-ID: <1352181848-24102-1-git-send-email-dongsheng.wang@freescale.com> (raw)
we should make sure a ethernet has been taken down when system into hibernation
status. when the system restoring form hibernation, the ethernet cannot be
taken up.
eg:
~# ifconfig eth0 down
~# echo disk > /sys/power/state
hibernation restore
~# ifconfig eth0 up
SIOCSIFFLAGS: No such device
Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
---
drivers/net/ethernet/freescale/gianfar.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index 4605f72..487b944 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -1345,8 +1345,11 @@ static int gfar_restore(struct device *dev)
struct gfar_private *priv = dev_get_drvdata(dev);
struct net_device *ndev = priv->ndev;
- if (!netif_running(ndev))
+ if (!netif_running(ndev)) {
+ netif_device_attach(ndev);
+
return 0;
+ }
gfar_init_bds(ndev);
init_registers(ndev);
--
1.7.5.1
next reply other threads:[~2012-11-06 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 6:04 Wang Dongsheng [this message]
2012-11-09 14:43 ` [PATCH] gianfar: ethernet vanishes after restoring from hibernation Paul Gortmaker
2012-11-09 16:02 ` Claudiu Manoil
2012-11-09 22:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352181848-24102-1-git-send-email-dongsheng.wang@freescale.com \
--to=dongsheng.wang@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).