From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net-next] 8021q: validate SAN MAC address Date: Sat, 10 Nov 2012 00:36:02 +0000 Message-ID: <1352507762.3159.26.camel@bwh-desktop.uk.solarflarecom.com> References: <1352501644-8444-1-git-send-email-mchan@broadcom.com> <1352502165.3159.21.camel@bwh-desktop.uk.solarflarecom.com> <1352507122.6276.2.camel@LTIRV-MCHAN1.corp.ad.broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , To: Michael Chan Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:61981 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581Ab2KJAgG (ORCPT ); Fri, 9 Nov 2012 19:36:06 -0500 In-Reply-To: <1352507122.6276.2.camel@LTIRV-MCHAN1.corp.ad.broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2012-11-09 at 16:25 -0800, Michael Chan wrote: > On Fri, 2012-11-09 at 23:02 +0000, Ben Hutchings wrote: > > > Some bnx2x multi-function devices are configured for FCoE only in > > > a PCI function and only has a SAN MAC address. The current code > > > will fail ->ndo_validate_addr() when a VLAN device is brought up > > > over such a device. > > > > > > Check the real device's dev_addrs[] for a valid SAN MAC address > > > when validating the MAC address if the regular MAC address is not > > > valid. > > > > So the VLAN device's own address is being completely ignored? > > No, it is not being ignored. We validate the VLAN's regular MAC address > first. If it is invalid, check further to see if the real device has a > SAN MAC address. Sure, but in the case that the VLAN device is layered on one of these FCoE SAN devices, the VLAN device's address isn't validated. Which presumably means it's not going to be used at all... What does the VLAN device actually do in this case? Is it a way of setting a VID to be used for the FCoE encapsulation? Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.