From: Mugunthan V N <mugunthanvnm@ti.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <devicetree-discuss@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <b-cousson@ti.com>,
<paul@pwsan.com>, Vaibhav Hiremath <hvaibhav@ti.com>,
Mugunthan V N <mugunthanvnm@ti.com>
Subject: [PATCH V5 1/7] net: davinci_mdio: Fix typo mistake in calling runtime-pm api
Date: Thu, 15 Nov 2012 00:37:54 +0530 [thread overview]
Message-ID: <1352920080-6179-2-git-send-email-mugunthanvnm@ti.com> (raw)
In-Reply-To: <1352920080-6179-1-git-send-email-mugunthanvnm@ti.com>
From: Vaibhav Hiremath <hvaibhav@ti.com>
By mistake (most likely a copy-paste), instead of pm_runtime_get_sync()
api, driver is calling pm_runtime_put_sync() api in resume callback
function. The bug was introduced by commit id (ae2c07aaf74:
davinci_mdio: runtime PM support).
Now, the reason why it didn't impact functionality is, the patch has
been tested on AM335x-EVM and BeagleBone platform while submitting;
and in case of AM335x the MDIO driver doesn't control the module
enable/disable part, which is handled by CPSW driver.
Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Acked-by: Richard Cochran <richardcochran@gmail.com>
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 51a96db..ae74280 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -465,7 +465,7 @@ static int davinci_mdio_resume(struct device *dev)
u32 ctrl;
spin_lock(&data->lock);
- pm_runtime_put_sync(data->dev);
+ pm_runtime_get_sync(data->dev);
/* restart the scan state machine */
ctrl = __raw_readl(&data->regs->control);
--
1.7.0.4
next prev parent reply other threads:[~2012-11-14 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 19:07 [PATCH V5 0/7] ARM: AM33XX: net: Add DT support to CPSW and MDIO driver Mugunthan V N
2012-11-14 19:07 ` Mugunthan V N [this message]
2012-11-14 19:07 ` [PATCH V5 2/7] net: cpsw: Add parent<->child relation support between cpsw and mdio Mugunthan V N
2012-11-14 19:07 ` [PATCH V5 3/7] cpsw: simplify the setup of the register pointers Mugunthan V N
[not found] ` <1352920080-6179-1-git-send-email-mugunthanvnm-l0cyMroinI0@public.gmane.org>
2012-11-14 19:07 ` [PATCH V5 4/7] net: cpsw: halt network stack before halting the device during suspend Mugunthan V N
2012-11-14 19:07 ` [PATCH V5 6/7] ARM: OMAP2+: omap2plus_defconfig: Enable CPSW support Mugunthan V N
2012-11-14 19:07 ` [PATCH V5 5/7] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio module Mugunthan V N
2012-11-14 19:08 ` [PATCH V5 7/7] arm/dts: am33xx: Add CPSW and MDIO module nodes for AM33XX Mugunthan V N
2012-11-19 20:24 ` Peter Korsgaard
2012-11-15 3:09 ` [PATCH V5 0/7] ARM: AM33XX: net: Add DT support to CPSW and MDIO driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352920080-6179-2-git-send-email-mugunthanvnm@ti.com \
--to=mugunthanvnm@ti.com \
--cc=b-cousson@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=hvaibhav@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox