From: Eric Dumazet <eric.dumazet@gmail.com>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 1/3] ipip: fix sparse warnings in ipip_netlink_parms()
Date: Thu, 15 Nov 2012 05:20:02 -0800 [thread overview]
Message-ID: <1352985602.4497.31.camel@edumazet-glaptop> (raw)
In-Reply-To: <50A4B8B0.1090409@6wind.com>
On Thu, 2012-11-15 at 10:41 +0100, Nicolas Dichtel wrote:
> Le 15/11/2012 09:53, Nicolas Dichtel a écrit :
> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> I forget "Reported-by: Fengguang Wu <fengguang.wu@intel.com>"
>
> Should I resend the serie?
Your patches generally lack changelogs and proper attribution.
Having a good changelog can avoid to actually look at the patch content,
its incredibly useful in the long term.
next prev parent reply other threads:[~2012-11-15 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 8:53 [PATCH net-next 1/3] ipip: fix sparse warnings in ipip_netlink_parms() Nicolas Dichtel
2012-11-15 8:53 ` [PATCH net-next 2/3] sit: fix sparse warnings Nicolas Dichtel
2012-11-15 8:53 ` [PATCH net-next 3/3] ip6tnl: fix sparse warnings in ip6_tnl_netlink_parms() Nicolas Dichtel
2012-11-15 9:41 ` [PATCH net-next 1/3] ipip: fix sparse warnings in ipip_netlink_parms() Nicolas Dichtel
2012-11-15 13:20 ` Eric Dumazet [this message]
2012-11-15 14:06 ` [PATCH net-next v2 " Nicolas Dichtel
2012-11-15 14:06 ` [PATCH net-next v2 2/3] sit: fix sparse warnings Nicolas Dichtel
2012-11-15 18:56 ` David Miller
2012-11-15 14:06 ` [PATCH net-next v2 3/3] ip6tnl: fix sparse warnings in ip6_tnl_netlink_parms() Nicolas Dichtel
2012-11-15 18:57 ` David Miller
2012-11-15 18:56 ` [PATCH net-next v2 1/3] ipip: fix sparse warnings in ipip_netlink_parms() David Miller
2012-11-15 13:15 ` [PATCH net-next " Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352985602.4497.31.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox