From: Eric Dumazet <eric.dumazet@gmail.com>
To: Willy Tarreau <w@1wt.eu>
Cc: netdev@vger.kernel.org
Subject: Re: GRO + splice panics in 3.7.0-rc5
Date: Thu, 15 Nov 2012 15:49:04 -0800 [thread overview]
Message-ID: <1353023344.10798.8.camel@edumazet-glaptop> (raw)
In-Reply-To: <20121115222812.GA647@1wt.eu>
On Thu, 2012-11-15 at 23:28 +0100, Willy Tarreau wrote:
> Hello,
>
> I was just about to make a quick comparison between LRO and GRO in
> 3.7.0-rc5 to see if LRO still had the big advantage I've always observed,
> but I failed the test because as soon as I enable LRO + splice, the kernel
> panics and reboots.
>
> I could not yet manage to catch the panic output, I could just reliably
> reproduce it, it crashes instantly.
>
> All I can say at the moment is the following :
> - test consist in forwarding HTTP traffic between two NICs via haproxy
> - driver used was myri10ge
> - LRO + recv+send : OK
> - LRO + splice : OK
> - GRO + recv+send : OK
> - GRO + splice : panic
> - no such problem was observed in 3.6.6 so I think this is a recent
> regression.
>
> I'll go back digging for more information, but as I'm used to often see
> Eric suggest the right candidates for reverting, I wanted to report the
> issue here in case there are easy ones to try first.
Hi Willy
Nothing particular comes to mind, there were a lot of recent changes
that could trigger this kind of bug.
A stack trace would be useful of course ;)
next prev parent reply other threads:[~2012-11-15 23:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 22:28 GRO + splice panics in 3.7.0-rc5 Willy Tarreau
2012-11-15 23:49 ` Eric Dumazet [this message]
2012-11-16 6:39 ` Willy Tarreau
2012-12-01 19:43 ` Willy Tarreau
2012-12-01 20:52 ` Willy Tarreau
2012-12-01 21:47 ` Eric Dumazet
2012-12-01 22:32 ` Eric Dumazet
2012-12-01 22:40 ` Willy Tarreau
2012-12-01 23:07 ` [PATCH net] tcp: fix crashes in do_tcp_sendpages() Eric Dumazet
2012-12-02 1:41 ` David Miller
2012-12-02 1:43 ` Joe Perches
2012-12-02 2:58 ` GRO + splice panics in 3.7.0-rc5 Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353023344.10798.8.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox