From: Antonio Quartulli <ordex@autistici.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org,
Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>,
Marek Lindner <lindner_marek@yahoo.de>,
Sven Eckelmann <sven@narfation.org>,
Antonio Quartulli <ordex@autistici.org>
Subject: [PATCH 3/4] batman-adv: don't add TEMP clients belonging to other backbone nodes
Date: Fri, 16 Nov 2012 09:49:17 +0100 [thread overview]
Message-ID: <1353055758-2901-4-git-send-email-ordex@autistici.org> (raw)
In-Reply-To: <1353055758-2901-1-git-send-email-ordex@autistici.org>
The "early client detection" mechanism must not add clients belonging
to other backbone nodes. Such clients must be reached by directly
using the LAN instead of the mesh.
This was introduced by 30cfd02b60e1cb16f5effb0a01f826c5bb7e4c59
("batman-adv: detect not yet announced clients")
Reported-by: Glen Page <glen.page@thet.net>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
net/batman-adv/translation-table.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index fec1a00..baae715 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -2456,6 +2456,13 @@ bool batadv_tt_add_temporary_global_entry(struct batadv_priv *bat_priv,
{
bool ret = false;
+ /* if the originator is a backbone node (meaning it belongs to the same
+ * LAN of this node) the temporary client must not be added because to
+ * reach such destination the node must use the LAN instead of the mesh
+ */
+ if (batadv_bla_is_backbone_gw_orig(bat_priv, orig_node->orig))
+ goto out;
+
if (!batadv_tt_global_add(bat_priv, orig_node, addr,
BATADV_TT_CLIENT_TEMP,
atomic_read(&orig_node->last_ttvn)))
--
1.8.0
next prev parent reply other threads:[~2012-11-16 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 8:49 pull request: batman-adv 2012-11-16 Antonio Quartulli
2012-11-16 8:49 ` [PATCH 1/4] batman-adv: fix tt_global_entries flags update Antonio Quartulli
2012-11-16 8:49 ` [PATCH 2/4] batman-adv: correctly pass the client flag on tt_response Antonio Quartulli
2012-11-16 8:49 ` Antonio Quartulli [this message]
2012-11-16 8:49 ` [PATCH 4/4] batman-adv: process broadcast packets in BLA earlier Antonio Quartulli
2012-11-16 18:39 ` pull request: batman-adv 2012-11-16 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353055758-2901-4-git-send-email-ordex@autistici.org \
--to=ordex@autistici.org \
--cc=davem@davemloft.net \
--cc=lindner_marek@yahoo.de \
--cc=netdev@vger.kernel.org \
--cc=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox