From: Joe Perches <joe@perches.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Rui Xiang <leo.ruixiang@gmail.com>,
serge.hallyn@canonical.com,
containers@lists.linux-foundation.org, netdev@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH RFC 3/5] printk: modify printk interface for syslog_namespace
Date: Mon, 19 Nov 2012 06:53:34 -0800 [thread overview]
Message-ID: <1353336814.5287.2.camel@joe-AO722> (raw)
In-Reply-To: <20121119142926.GB4453@mail.hallyn.com>
On Mon, 2012-11-19 at 14:29 +0000, Serge E. Hallyn wrote:
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
48kb of quoted text...
> > @@ -1678,7 +1674,7 @@ asmlinkage int printk(const char *fmt, ...)
> > }
> > #endif
> > va_start(args, fmt);
> > - r = vprintk_emit(0, -1, NULL, 0, fmt, args);
> > + r = vprintk_emit(0, -1, NULL, 0, fmt, args, current_syslog_ns());
>
> Current is meaningless here. The default should be using init_syslog_ns.
For a single sentence. Please remember to trim your replies.
next prev parent reply other threads:[~2012-11-19 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 8:16 [PATCH RFC 3/5] printk: modify printk interface for syslog_namespace Rui Xiang
2012-11-19 14:29 ` Serge E. Hallyn
2012-11-19 14:53 ` Joe Perches [this message]
[not found] ` <20121119142926.GB4453-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2012-11-21 9:41 ` Rui Xiang
[not found] ` <50A9EAF0.4000902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-21 17:49 ` Serge E. Hallyn
-- strict thread matches above, loose matches on Subject: below --
2012-11-24 11:22 Libo Chen
[not found] ` <50B0ADDB.4000303-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-25 4:28 ` Serge E. Hallyn
[not found] ` <20121125042802.GB4523-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2012-11-27 13:25 ` Libo Chen
[not found] ` <50B4BF64.6010707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-27 13:58 ` Serge Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353336814.5287.2.camel@joe-AO722 \
--to=joe@perches.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=leo.ruixiang@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).