Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Lluís Batlle i Rossell" <viric@viric.name>,
	"David Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: unable to handle paging request, arm, at aio/tcp code, only 3.6
Date: Mon, 19 Nov 2012 13:34:18 -0800	[thread overview]
Message-ID: <1353360858.10798.86.camel@edumazet-glaptop> (raw)
In-Reply-To: <1353354095.10798.76.camel@edumazet-glaptop>

From: Eric Dumazet <edumazet@google.com>

> Thanks for the report.
> 
> I believe this is a regression of commit
> 35ad9b9cf7d8a2e6259a0d24022e910adb6f3489
> (ipv6: Add helper inet6_csk_update_pmtu().)
> 
> I'll prepare a patch to fix this.

Please try the following fix.

Thanks !

[PATCH] ipv6: fix inet6_csk_update_pmtu() return value

In case of error, inet6_csk_update_pmtu() should consistently
return NULL.

Bug added in commit 35ad9b9cf7d8a 
(ipv6: Add helper inet6_csk_update_pmtu().)

Reported-by: Lluís Batlle i Rossell <viric@viric.name>
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/ipv6/inet6_connection_sock.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
index c4f9341..3064785 100644
--- a/net/ipv6/inet6_connection_sock.c
+++ b/net/ipv6/inet6_connection_sock.c
@@ -252,6 +252,7 @@ struct dst_entry *inet6_csk_update_pmtu(struct sock *sk, u32 mtu)
 		return NULL;
 	dst->ops->update_pmtu(dst, sk, NULL, mtu);
 
-	return inet6_csk_route_socket(sk, &fl6);
+	dst = inet6_csk_route_socket(sk, &fl6);
+	return IS_ERR(dst) ? NULL : dst;
 }
 EXPORT_SYMBOL_GPL(inet6_csk_update_pmtu);

  parent reply	other threads:[~2012-11-19 21:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 18:32 unable to handle paging request, arm, at aio/tcp code, only 3.6 Lluís Batlle i Rossell
2012-11-19 19:41 ` Eric Dumazet
2012-11-19 21:10   ` Lluís Batlle i Rossell
2012-11-19 21:36     ` Eric Dumazet
2012-11-19 21:34   ` Eric Dumazet [this message]
2012-11-20  6:55     ` Lluís Batlle i Rossell
2012-11-20 20:18     ` David Miller
2012-11-20 21:26       ` Lluís Batlle i Rossell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353360858.10798.86.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=viric@viric.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox