From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>,
Stefan Bader <stefan.bader@canonical.com>,
Sander Eikelenboom <linux@eikelenboom.it>,
Eric Dumazet <edumazet@google.com>,
KonradRzeszutekWilk <konrad@kernel.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
ANNIE LI <annie.li@oracle.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/netfront: handle compound page fragments on transmit
Date: Tue, 20 Nov 2012 07:28:28 -0800 [thread overview]
Message-ID: <1353425308.2590.11.camel@edumazet-glaptop> (raw)
In-Reply-To: <1353424014.13542.49.camel@zakaz.uk.xensource.com>
On Tue, 2012-11-20 at 15:06 +0000, Ian Campbell wrote:
> In practice no because of the property that the number of pages backing
> the frags is <= MAX_SKB_FRAGS even if you are using compound pages as
> the frags.
Yes, but you can make this test trigger with some hacks from userland
(since the frag allocator is per task instead of per socket), so you
should remove the dump_stack() ?
Best way would be to count exact number of slots.
This could be something like 48 slots for a single skb
(if each frag is 4098 (1+4096+1)bytes, only the last one is around 4000
bytes)
MAX_SKB_FRAGS is really number of frags, while your driver needs a count
of 'order-0' 'frames'
next prev parent reply other threads:[~2012-11-20 15:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 13:47 compound skb frag pages appearing in start_xmit Ian Campbell
2012-10-09 13:54 ` Eric Dumazet
2012-10-09 14:01 ` Eric Dumazet
2012-10-09 14:23 ` Ian Campbell
2012-10-09 14:33 ` Eric Dumazet
2012-10-09 14:54 ` Ian Campbell
2012-10-09 14:17 ` Ian Campbell
2012-10-09 14:27 ` Eric Dumazet
2012-10-09 14:40 ` Ian Campbell
2012-10-09 14:51 ` Eric Dumazet
2012-10-10 10:13 ` [Xen-devel] " Ian Campbell
2012-10-10 12:24 ` Sander Eikelenboom
2012-10-10 12:29 ` [Xen-devel] " Ian Campbell
2012-10-10 13:31 ` Sander Eikelenboom
2012-10-10 13:09 ` Ian Campbell
2012-10-10 14:49 ` Sander Eikelenboom
2012-10-11 8:02 ` Ian Campbell
2012-10-11 10:00 ` Sander Eikelenboom
2012-10-11 10:05 ` Eric Dumazet
2012-10-11 10:14 ` Ian Campbell
2012-10-11 10:20 ` Sander Eikelenboom
2012-11-15 2:31 ` ANNIE LI
2012-11-19 15:43 ` Sander Eikelenboom
2012-11-20 8:30 ` [Xen-devel] " Stefan Bader
2012-11-20 9:21 ` Ian Campbell
2012-11-20 11:36 ` [Xen-devel] " Ian Campbell
2012-11-21 2:42 ` ANNIE LI
2012-11-20 11:40 ` [PATCH] xen/netfront: handle compound page fragments on transmit Ian Campbell
2012-11-20 12:28 ` [Xen-devel] " Jan Beulich
2012-11-20 13:35 ` Ian Campbell
2012-11-20 13:51 ` Jan Beulich
2012-11-20 14:14 ` Ian Campbell
2012-11-20 14:32 ` Jan Beulich
2012-11-20 15:06 ` Ian Campbell
2012-11-20 15:28 ` Eric Dumazet [this message]
2012-11-20 15:54 ` Ian Campbell
2012-11-20 15:44 ` Jan Beulich
2012-11-20 16:14 ` Eric Dumazet
2012-11-20 13:30 ` Stefan Bader
2012-11-20 13:45 ` Sander Eikelenboom
2012-11-20 14:45 ` Eric Dumazet
2012-11-20 15:05 ` Ian Campbell
2012-11-21 2:52 ` ANNIE LI
2012-11-21 11:09 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353425308.2590.11.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=annie.li@oracle.com \
--cc=edumazet@google.com \
--cc=konrad@kernel.org \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=stefan.bader@canonical.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox