From: Joe Perches <joe@perches.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Eilon Greenstein <eilong@broadcom.com>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] checkpatch: add double empty line check
Date: Tue, 20 Nov 2012 15:41:14 -0800 [thread overview]
Message-ID: <1353454874.17819.41.camel@joe-AO722> (raw)
In-Reply-To: <20121120231930.GA27492@localhost>
On Tue, 2012-11-20 at 23:19 +0000, Andy Whitcroft wrote:
> On Tue, Nov 20, 2012 at 01:58:48PM -0800, Joe Perches wrote:
>
> > +# check for multiple blank lines, warn only on the second one in a block
> > + if ($rawline =~ /^.\s*$/ &&
> > + $prevrawline =~ /^.\s*$/ &&
> > + $linenr != $last_blank_linenr + 1) {
> > + CHK("DOUBLE_EMPTY_LINE",
> > + "One blank line separating blocks is generally sufficient\n" . $herecurr);
> > + $last_blank_linenr = $linenr;
> > + }
> > +
> > # check for line continuations in quoted strings with odd counts of "
> > if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
> > WARN("LINE_CONTINUATIONS",
>
> Pretty sure that will fail with combination which have removed lines.
Not as far as I can tell.
Deleted lines followed by inserted lines seem
to work OK.
This check is located after the test that ensures
the current $line/$rawline is an insertion.
> I have a version here which I am testing with the combinations I have
> isolated to far ...
Enjoy.
Can you please test my proposal against those combinations too?
cheers, Joe
next prev parent reply other threads:[~2012-11-20 23:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 11:17 [PATCH v2] checkpatch: add double empty line check Eilon Greenstein
2012-11-20 11:52 ` Andy Whitcroft
2012-11-20 14:27 ` Eilon Greenstein
2012-11-20 14:43 ` Andy Whitcroft
2012-11-20 15:07 ` Eilon Greenstein
2012-11-20 15:44 ` Andy Whitcroft
2012-11-20 16:06 ` Eilon Greenstein
2012-11-20 16:14 ` Andy Whitcroft
2012-11-20 16:22 ` Eilon Greenstein
2012-11-20 16:36 ` Andy Whitcroft
2012-11-20 16:36 ` Andy Whitcroft
2012-11-20 19:10 ` Eilon Greenstein
2012-11-20 19:32 ` Andy Whitcroft
2012-11-20 20:11 ` Andy Whitcroft
2012-11-20 20:26 ` Eilon Greenstein
2012-11-20 21:58 ` Joe Perches
2012-11-20 23:19 ` Andy Whitcroft
2012-11-20 23:41 ` Joe Perches [this message]
2012-11-21 9:42 ` Eilon Greenstein
2012-11-21 15:01 ` Joe Perches
2012-11-21 15:45 ` Eilon Greenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353454874.17819.41.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=eilong@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).