From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: sarveshwar.bandi@emulex.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] bonding: Bonding driver does not consider the gso_max_size setting of slaves.
Date: Wed, 21 Nov 2012 06:44:47 -0800 [thread overview]
Message-ID: <1353509087.2590.32.camel@edumazet-glaptop> (raw)
In-Reply-To: <20121121115601.GA5579@hmsreliant.think-freely.org>
On Wed, 2012-11-21 at 06:56 -0500, Neil Horman wrote:
> This seems a bit overly complex. It doesn't seem like you need the
> reset_go_size bool in here at all. Just initalize gso_max_size to GSO_MAX_SIZE
> and reduce it every time you find a smaller gso value on a slave. Then you can
> unilaterally set the bond devices gso_max_size without having to check any bools
> or do any comparisons.
Oh well, I should have read your answer ;)
next prev parent reply other threads:[~2012-11-21 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 11:18 [PATCH net-2.6] bonding: Bonding driver does not consider the gso_max_size setting of slaves sarveshwar.bandi
2012-11-21 11:56 ` Neil Horman
2012-11-21 12:03 ` Bandi,Sarveshwar
2012-11-21 14:44 ` Eric Dumazet [this message]
2012-11-21 14:43 ` Eric Dumazet
2012-11-21 14:44 ` Bandi,Sarveshwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353509087.2590.32.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=sarveshwar.bandi@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox