From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: netdev@vger.kernel.org, xen-devel@lists.xen.org,
Eric Dumazet <edumazet@google.com>,
Konrad Rzeszutek Wilk <konrad@kernel.org>,
ANNIE LI <annie.li@oracle.com>,
Sander Eikelenboom <linux@eikelenboom.it>,
Stefan Bader <stefan.bader@canonical.com>
Subject: Re: [PATCH V3] xen/netfront: handle compound page fragments on transmit
Date: Wed, 21 Nov 2012 07:13:52 -0800 [thread overview]
Message-ID: <1353510832.2590.39.camel@edumazet-glaptop> (raw)
In-Reply-To: <1353499336-28952-1-git-send-email-ian.campbell@citrix.com>
On Wed, 2012-11-21 at 12:02 +0000, Ian Campbell wrote:
> An SKB paged fragment can consist of a compound page with order > 0.
> However the netchannel protocol deals only in PAGE_SIZE frames.
>
> Handle this in xennet_make_frags by iterating over the frames which
> make up the page.
>
> This is the netfront equivalent to 6a8ed462f16b for netback.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: netdev@vger.kernel.org
> Cc: xen-devel@lists.xen.org
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>
> Cc: ANNIE LI <annie.li@oracle.com>
> Cc: Sander Eikelenboom <linux@eikelenboom.it>
> Cc: Stefan Bader <stefan.bader@canonical.com>
> ---
> v3: limit to 80-characters. Use net_alert_ratelimited.
> v2: check we have enough room in the ring and that the other end can
> cope with the number of slots in a single frame
> ---
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2012-11-21 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 12:02 [PATCH V3] xen/netfront: handle compound page fragments on transmit Ian Campbell
2012-11-21 13:45 ` [Xen-devel] " Stefan Bader
2012-11-21 15:13 ` Eric Dumazet [this message]
2012-11-21 15:16 ` Konrad Rzeszutek Wilk
2012-11-21 16:49 ` David Miller
2012-11-22 14:15 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353510832.2590.39.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=annie.li@oracle.com \
--cc=edumazet@google.com \
--cc=ian.campbell@citrix.com \
--cc=konrad@kernel.org \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=stefan.bader@canonical.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox