netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH net-next 9/9] tipc: delete TIPC_ADVANCED Kconfig variable
Date: Thu, 22 Nov 2012 15:59:54 -0500	[thread overview]
Message-ID: <1353617994-3962-10-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1353617994-3962-1-git-send-email-paul.gortmaker@windriver.com>

There used to be a time when TIPC had lots of Kconfig knobs the
end user could alter, but they have all been made automatic or
obsolete, with the exception of CONFIG_TIPC_PORTS.  This
previously existing set of options was all hidden under the
TIPC_ADVANCED setting, which does not exist in any code, but
only in Kconfig scope.

Having this now, just to hide the one remaining "advanced"
option no longer makes sense.  Remove it.  Also get rid of the
ifdeffery in the TIPC code that allowed for TIPC_PORTS to be
possibly undefined.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 net/tipc/Kconfig | 13 +------------
 net/tipc/core.c  |  5 -----
 2 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig
index 5854601..bc41bd3 100644
--- a/net/tipc/Kconfig
+++ b/net/tipc/Kconfig
@@ -20,18 +20,9 @@ menuconfig TIPC
 
 	  If in doubt, say N.
 
-if TIPC
-
-config TIPC_ADVANCED
-	bool "Advanced TIPC configuration"
-	default n
-	help
-	  Saying Y here will open some advanced configuration for TIPC.
-	  Most users do not need to bother; if unsure, just say N.
-
 config TIPC_PORTS
 	int "Maximum number of ports in a node"
-	depends on TIPC_ADVANCED
+	depends on TIPC
 	range 127 65535
 	default "8191"
 	help
@@ -40,5 +31,3 @@ config TIPC_PORTS
 
 	  Setting this to a smaller value saves some memory,
 	  setting it to higher allows for more ports.
-
-endif # TIPC
diff --git a/net/tipc/core.c b/net/tipc/core.c
index bfe8af8..fc05cec 100644
--- a/net/tipc/core.c
+++ b/net/tipc/core.c
@@ -42,11 +42,6 @@
 
 #include <linux/module.h>
 
-#ifndef CONFIG_TIPC_PORTS
-#define CONFIG_TIPC_PORTS 8191
-#endif
-
-
 /* global variables used by multiple sub-systems within TIPC */
 int tipc_random __read_mostly;
 
-- 
1.7.12.1

  parent reply	other threads:[~2012-11-22 21:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22 20:59 [PATCH net-next 0/9] tipc: updates for what will be v3.8 Paul Gortmaker
2012-11-22 20:59 ` [PATCH net-next 1/9] tipc: fix race/inefficiencies in poll/wait behaviour Paul Gortmaker
2012-11-22 20:59 ` [PATCH net-next 2/9] tipc: return POLLOUT for sockets in an unconnected state Paul Gortmaker
2012-11-22 20:59 ` [PATCH net-next 3/9] tipc: wake up all waiting threads at socket shutdown Paul Gortmaker
2012-11-22 20:59 ` [PATCH net-next 4/9] tipc: remove the bearer congestion mechanism Paul Gortmaker
2012-11-22 20:59 ` [PATCH net-next 5/9] tipc: remove supportable flag from bclink structure Paul Gortmaker
2012-11-22 20:59 ` [PATCH net-next 6/9] tipc: rename supported flag to recv_permitted Paul Gortmaker
2012-11-22 20:59 ` [PATCH net-next 7/9] tipc: introduce message to synchronize broadcast link Paul Gortmaker
2012-11-22 20:59 ` [PATCH net-next 8/9] tipc: eliminate an unnecessary cast of node variable Paul Gortmaker
2012-11-22 20:59 ` Paul Gortmaker [this message]
2012-11-23 19:10 ` [PATCH net-next 0/9] tipc: updates for what will be v3.8 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353617994-3962-10-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).