netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	Sven Eckelmann <sven@narfation.org>
Subject: [PATCH 5/7] batman-adv: Allow to postpone softif unregistration
Date: Sat, 24 Nov 2012 01:02:10 +0100	[thread overview]
Message-ID: <1353715332-4284-5-git-send-email-sven@narfation.org> (raw)
In-Reply-To: <1353715332-4284-1-git-send-email-sven@narfation.org>

The caller of batadv_softif_destroy may want to postpone the unregistration of
the soft-interface. This is necessary when the rtnl_link configuration hooks
are used.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 net/batman-adv/hard-interface.c |    2 +-
 net/batman-adv/soft-interface.c |    5 +++--
 net/batman-adv/soft-interface.h |    3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
index daeb632..5e2655d 100644
--- a/net/batman-adv/hard-interface.c
+++ b/net/batman-adv/hard-interface.c
@@ -447,7 +447,7 @@ void batadv_hardif_disable_interface(struct batadv_hard_iface *hard_iface,
 
 	/* nobody uses this interface anymore */
 	if (!bat_priv->num_ifaces && autodel == BATADV_IF_CLEANUP_AUTO)
-		batadv_softif_destroy(hard_iface->soft_iface);
+		batadv_softif_destroy(hard_iface->soft_iface, NULL);
 
 	hard_iface->soft_iface = NULL;
 	batadv_hardif_free_ref(hard_iface);
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index 5fd0560..68832f5 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -544,7 +544,8 @@ struct net_device *batadv_softif_create(const char *name)
 	return soft_iface;
 }
 
-void batadv_softif_destroy(struct net_device *soft_iface)
+void batadv_softif_destroy(struct net_device *soft_iface,
+			   struct list_head *head)
 {
 	struct batadv_hard_iface *hard_iface;
 
@@ -555,7 +556,7 @@ void batadv_softif_destroy(struct net_device *soft_iface)
 	}
 
 	batadv_sysfs_del_meshif(soft_iface);
-	unregister_netdevice(soft_iface);
+	unregister_netdevice_queue(soft_iface, head);
 }
 
 int batadv_softif_is_valid(const struct net_device *net_dev)
diff --git a/net/batman-adv/soft-interface.h b/net/batman-adv/soft-interface.h
index 07a08fe..fe9b0f7 100644
--- a/net/batman-adv/soft-interface.h
+++ b/net/batman-adv/soft-interface.h
@@ -25,7 +25,8 @@ void batadv_interface_rx(struct net_device *soft_iface,
 			 struct sk_buff *skb, struct batadv_hard_iface *recv_if,
 			 int hdr_size, struct batadv_orig_node *orig_node);
 struct net_device *batadv_softif_create(const char *name);
-void batadv_softif_destroy(struct net_device *soft_iface);
+void batadv_softif_destroy(struct net_device *soft_iface,
+			   struct list_head *head);
 int batadv_softif_is_valid(const struct net_device *net_dev);
 
 #endif /* _NET_BATMAN_ADV_SOFT_INTERFACE_H_ */
-- 
1.7.10.4

  parent reply	other threads:[~2012-11-24  0:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-24  0:02 [PATCH 1/7] batman-adv: Move soft-interface initialization to ndo_init Sven Eckelmann
2012-11-24  0:02 ` [PATCH 2/7] batman-adv: Move deinitialization of soft-interface to destructor Sven Eckelmann
2012-11-24  0:02 ` [PATCH 3/7] batman-adv: Don't always delete softif when last slave was removed Sven Eckelmann
2012-11-24  0:02 ` [PATCH 4/7] batman-adv: Remove slave interfaces before removing master interface Sven Eckelmann
2012-11-24  0:02 ` Sven Eckelmann [this message]
2012-11-24  0:02 ` [PATCH 6/7] batman-adv: Allow to use rntl_link for device creation/deletion Sven Eckelmann
     [not found]   ` <20121201131108.GL24115@ritirata.org>
     [not found]     ` <20121201131108.GL24115-E/2OGukznS5g9hUCZPvPmw@public.gmane.org>
2012-12-01 13:16       ` Sven Eckelmann
2012-12-01 13:28         ` Re: [B.A.T.M.A.N.] " Antonio Quartulli
     [not found]           ` <20121201132802.GM24115-E/2OGukznS5g9hUCZPvPmw@public.gmane.org>
2012-12-01 13:39             ` Sven Eckelmann
2012-12-01 14:54               ` Re: Re: [B.A.T.M.A.N.] " Antonio Quartulli
2012-11-24  0:02 ` [PATCH 7/7] batman-adv: Allow to modify slaves of soft-interfaces through rntl_link Sven Eckelmann
2012-11-24 20:59 ` [PATCH 1/7] batman-adv: Move soft-interface initialization to ndo_init David Miller
     [not found]   ` <20121124.155902.1261596975089040930.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-11-24 21:23     ` Sven Eckelmann
2012-12-24 14:22 ` Pau Koning
     [not found]   ` <CANiGF9_=svx+W4Rhx8BL1NBv0H1aULeh71sX9YkMeR66OmmimA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-24 14:37     ` Marek Lindner
     [not found]       ` <201212242237.07208.lindner_marek-LWAfsSFWpa4@public.gmane.org>
2012-12-24 15:36         ` Pau Koning
2012-12-24 19:37           ` [B.A.T.M.A.N.] " Marek Lindner
2012-12-24 23:18             ` Pau Koning
     [not found]               ` <CANiGF9_4QP0ts2kV9Bruk_8L7h1870LMcrRhtsYu35q=COF0hQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-25  8:19                 ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353715332-4284-5-git-send-email-sven@narfation.org \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).