Netdev List
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	kbuild test robot <fengguang.wu@intel.com>, <davem@davemloft.net>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next:master 20/25] net/dsa: make DSA tagging depend on NETDEVICES and !S390
Date: Mon, 26 Nov 2012 18:57:35 +0000	[thread overview]
Message-ID: <1353956255.2717.1.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <50B3B9F6.5060509@infradead.org>

On Mon, 2012-11-26 at 10:50 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix kconfig dependency warning by making DSA support depend on the
> same kconfig symbols that NET_DSA depend on.
> 
> warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && NETDEVICES && !S390)

This perhaps ought to be abstracted into a HAVE_NET_DSA rather than
reepated here.  Also, in net-next NET_DSA still depends on EXPERIMENTAL,
which should be removed.

Ben.

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
>  net/dsa/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20121126.orig/net/dsa/Kconfig
> +++ linux-next-20121126/net/dsa/Kconfig
> @@ -9,6 +9,7 @@ config NET_DSA
>  
> 
>  menu "Distributed Switch Architecture support"
> +	depends on NETDEVICES && !S390
>  
>  # tagging formats
>  config NET_DSA_TAG_DSA

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

      reply	other threads:[~2012-11-26 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-26  4:56 [net-next:master 20/25] warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390) kbuild test robot
2012-11-26  6:13 ` Viresh Kumar
2012-11-26 18:50   ` [PATCH net-next:master 20/25] net/dsa: make DSA tagging depend on NETDEVICES and !S390 Randy Dunlap
2012-11-26 18:57     ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353956255.2717.1.camel@bwh-desktop.uk.solarflarecom.com \
    --to=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=fengguang.wu@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox