From: Joe Perches <joe@perches.com>
To: Rami Rosen <ramirose@gmail.com>
Cc: davem@davemloft.net, maxk@qti.qualcomm.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] tun: put correct method name in a debug message.
Date: Mon, 26 Nov 2012 14:31:19 -0800 [thread overview]
Message-ID: <1353969079.2493.5.camel@joe-AO722> (raw)
In-Reply-To: <1353917261-2974-3-git-send-email-ramirose@gmail.com>
On Mon, 2012-11-26 at 10:07 +0200, Rami Rosen wrote:
> This patch puts the correct method name, tun_do_read, in a debug message.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> drivers/net/tun.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 1dfb135..607a3a5 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -1296,7 +1296,7 @@ static ssize_t tun_do_read(struct tun_struct *tun, struct tun_file *tfile,
> struct sk_buff *skb;
> ssize_t ret = 0;
>
> - tun_debug(KERN_INFO, tun, "tun_chr_read\n");
> + tun_debug(KERN_INFO, tun, "tun_do_read\n");
It's almost always better to use "%s\n", __func__
Of course for these sorts of trivial tracing functions,
it's better to use the function tracer instead.
http://lwn.net/Articles/370423/
next prev parent reply other threads:[~2012-11-26 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 8:07 [PATCH net-next 0/2] tun: trivial fixes Rami Rosen
2012-11-26 8:07 ` [PATCH net-next 1/2] vtun: fix typos Rami Rosen
2012-11-26 8:07 ` [PATCH net-next 2/2] tun: put correct method name in a debug message Rami Rosen
2012-11-26 22:31 ` Joe Perches [this message]
2012-11-26 22:22 ` [PATCH net-next 0/2] tun: trivial fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353969079.2493.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=maxk@qti.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).