From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: BQL support in gianfar causes network hickup Date: Tue, 27 Nov 2012 05:49:46 -0800 Message-ID: <1354024186.7553.1744.camel@edumazet-glaptop> References: <9AA65D849A88EB44B5D9B6A8BA098E23040A60D6EE6E@Exchange1.lawo.de> <50AFA599.9040108@windriver.com> <1353800616.2590.4562.camel@edumazet-glaptop> <20121126100111.GA3728@mac.home> <1353947677.7553.2.camel@edumazet-glaptop> <9AA65D849A88EB44B5D9B6A8BA098E23040A60D6EE6F@Exchange1.lawo.de> <1353950255.7553.6.camel@edumazet-glaptop> <9AA65D849A88EB44B5D9B6A8BA098E23040A60D6EE70@Exchange1.lawo.de> <1354019816.7553.1585.camel@edumazet-glaptop> <9AA65D849A88EB44B5D9B6A8BA098E23040A60D6EE71@Exchange1.lawo.de> <1354023162.7553.1708.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Tino Keitel , Paul Gortmaker , "netdev@vger.kernel.org" To: "Keitel, Tino (ALC NetworX GmbH)" Return-path: Received: from mail-ia0-f174.google.com ([209.85.210.174]:52379 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286Ab2K0Ntx (ORCPT ); Tue, 27 Nov 2012 08:49:53 -0500 Received: by mail-ia0-f174.google.com with SMTP id y25so8959235iay.19 for ; Tue, 27 Nov 2012 05:49:53 -0800 (PST) In-Reply-To: <1354023162.7553.1708.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2012-11-27 at 05:32 -0800, Eric Dumazet wrote: > Can you reproduce the problem without PTP running, or disabled in the > driver ? > > (comment the "priv->hwts_tx_en = 1;" line) > > > This looks like we miss an interrupt ( or TXBD_INTERRUPT not correctly > set) > > And it could be a bug occurring if we try to send one skb with fragments > and skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP > > By the way are any errata flagged in gfar_detect_errata() ?