Re: [PATCH net-next] net: move inet_dport/inet_num in sock_common

Eric Dumazet
2012-11-27T21:23:24Z

On Tue, 2012-11-27 at 19:05 +0000, Ben Hutchings wrote:
> On Tue, 2012-11-27 at 07:06 -0800, Eric Dumazet wrote:

> > struct sock_common {
> > - /* skc_daddr and skc_rcv_saddr must be grouped :
> > - * cf INET_MATCH() and INET_TW_MATCH()
> > + /* skc_daddr and skc_rcv_saddr must be grouped on a 8 bytes aligned
> > + * address on 64bit arches : cf INET_MATCH() and INET_TW_MATCH()
>
> __aligned(8)?

Nope, only on 64 bit this requirement exists (since a long time)

I am not sure we want complexity on this.

And we dont want holes to be automatically added here neither.