Re: [PATCH net-next] net: move inet_dport/inet_num in sock_common

Ben Hutchings
2012-11-28T03:55:16Z

On Tue, 2012-11-27 at 19:31 -0800, Joe Perches wrote:
> On Wed, 2012-11-28 at 03:12 +0000, Ben Hutchings wrote:
> > On Tue, 2012-11-27 at 18:23 -0800, Joe Perches wrote:
> > > OK, so it's an and not an or. Duh.
> > [...]
> >
> > The way to combine these sorts of comparisons is along the lines of:
> >
> > (((left->a ^ right->a) |
> > (left->b ^ right->b) |
> > ...) == 0)
> >
> > But when there are big-endian types involved, sparse is likely to
> > complain about combining them.
>
> I believe there's only the 2 items that could be combined
> for cacheline purposes so using 2 logical tests with AND
> seems more readable. Maybe a single combined test would
> be faster. I don't have equipment at hand to test it.
>
> If you prefer I supposed it could be converted.

I don't particularly care, and I gave up this trick myself because it
didn't seem worth fighting sparse.

Ben.

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.