Netdev List
 help / color / mirror / Atom feed
From: Steve Glendinning <steve.glendinning@shawell.net>
To: netdev@vger.kernel.org
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Subject: [PATCH 1/6] smsc75xx: check return code from smsc75xx_reset
Date: Wed, 28 Nov 2012 15:59:45 +0000	[thread overview]
Message-ID: <1354118391-22666-2-git-send-email-steve.glendinning@shawell.net> (raw)
In-Reply-To: <1354118391-22666-1-git-send-email-steve.glendinning@shawell.net>

This patch adds a missing check and error message if smsc75xx_reset
fails.

Signed-off-by: Steve Glendinning <steve.glendinning@shawell.net>
---
 drivers/net/usb/smsc75xx.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c
index 953c4f4..a36648b 100644
--- a/drivers/net/usb/smsc75xx.c
+++ b/drivers/net/usb/smsc75xx.c
@@ -1163,6 +1163,7 @@ static int smsc75xx_bind(struct usbnet *dev, struct usb_interface *intf)
 
 	/* Init all registers */
 	ret = smsc75xx_reset(dev);
+	check_warn_return(ret, "smsc75xx_reset error %d\n", ret);
 
 	dev->net->netdev_ops = &smsc75xx_netdev_ops;
 	dev->net->ethtool_ops = &smsc75xx_ethtool_ops;
-- 
1.7.10.4

  reply	other threads:[~2012-11-28 16:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 15:59 [PATCH 0/6] smsc75xx enhancements Steve Glendinning
2012-11-28 15:59 ` Steve Glendinning [this message]
2012-11-28 15:59 ` [PATCH 2/6] smsc75xx: refactor entering suspend modes Steve Glendinning
2012-11-28 15:59 ` [PATCH 3/6] smsc75xx: support PHY wakeup source Steve Glendinning
2012-11-28 15:59 ` [PATCH 4/6] smsc75xx: fix error handling in suspend failure case Steve Glendinning
2012-11-28 15:59 ` [PATCH 5/6] smsc75xx: add support for USB dynamic autosuspend Steve Glendinning
2012-11-28 15:59 ` [PATCH 6/6] smsc75xx: don't enable remote wakeup directly Steve Glendinning
2012-11-28 16:17 ` [PATCH 0/6] smsc75xx enhancements David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354118391-22666-2-git-send-email-steve.glendinning@shawell.net \
    --to=steve.glendinning@shawell.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox