From: Cong Wang <amwang@redhat.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Herbert Xu <herbert@gondor.hengli.com.au>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Thomas Graf <tgraf@suug.ch>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v2] bridge: export multicast database via netlink
Date: Wed, 05 Dec 2012 10:08:59 +0800 [thread overview]
Message-ID: <1354673339.28951.3.camel@cr0> (raw)
In-Reply-To: <20121204085320.3e08986a@nehalam.linuxnetplumber.net>
On Tue, 2012-12-04 at 08:53 -0800, Stephen Hemminger wrote:
> On Mon, 3 Dec 2012 21:03:43 +0800
> Cong Wang <amwang@redhat.com> wrote:
>
> > V2: drop patch 1/2, export ifindex directly
> > Redesign netlink attributes
> > Improve netlink seq check
> > Handle IPv6 addr as well
> >
> > TODO: remove debugging printk's
> >
> > This patch exports bridge multicast database via netlink
> > message type RTM_GETMDB. Similar to fdb, but currently bridge-specific.
> > We may need to support modify multicast database too (RTM_{ADD,DEL}MDB).
> >
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: Stephen Hemminger <shemminger@vyatta.com>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Thomas Graf <tgraf@suug.ch>
> > Cc: Jesper Dangaard Brouer <brouer@redhat.com>
> > Signed-off-by: Cong Wang <amwang@redhat.com>
> >
>
> Minor nit reported by checkpatch was the messages should be using the api
> which provides the most info in the log to identify.
>
> WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
> #190: FILE: net/bridge/br_mdb.c:28:
> + printk(KERN_INFO "no router on bridge\n")
>
> There is a set of macro's already for use in bridging code:
> br_info(br, "no router on bridge\n");
>
Never mind, removing these printk's is in my TODO list. :)
next prev parent reply other threads:[~2012-12-05 2:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 13:03 [PATCH net-next v2] bridge: export multicast database via netlink Cong Wang
2012-12-03 13:03 ` [PATCH iproute2 v2] Add mdb command to bridge Cong Wang
2012-12-04 16:53 ` [PATCH net-next v2] bridge: export multicast database via netlink Stephen Hemminger
2012-12-05 2:08 ` Cong Wang [this message]
2012-12-04 18:25 ` David Miller
2012-12-05 2:07 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354673339.28951.3.camel@cr0 \
--to=amwang@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).