* Re: [Patch net-next] xfrm: add missing xfrm message types to selinux perm table
[not found] <1354599571-6181-1-git-send-email-amwang@redhat.com>
@ 2012-12-04 18:02 ` David Miller
2012-12-05 5:41 ` Steffen Klassert
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2012-12-04 18:02 UTC (permalink / raw)
To: amwang; +Cc: netdev, steffen.klassert, herbert
From: Cong Wang <amwang@redhat.com>
Date: Tue, 4 Dec 2012 13:39:31 +0800
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Steffen will you take this into your IPSEC tree?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Patch net-next] xfrm: add missing xfrm message types to selinux perm table
2012-12-04 18:02 ` [Patch net-next] xfrm: add missing xfrm message types to selinux perm table David Miller
@ 2012-12-05 5:41 ` Steffen Klassert
2012-12-05 6:56 ` Cong Wang
0 siblings, 1 reply; 6+ messages in thread
From: Steffen Klassert @ 2012-12-05 5:41 UTC (permalink / raw)
To: David Miller; +Cc: amwang, netdev, herbert
On Tue, Dec 04, 2012 at 01:02:57PM -0500, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Tue, 4 Dec 2012 13:39:31 +0800
>
> > Cc: Steffen Klassert <steffen.klassert@secunet.com>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Signed-off-by: Cong Wang <amwang@redhat.com>
>
> Steffen will you take this into your IPSEC tree?
>
I would do so, but I have not seen this patch by now.
Was it really send to me? I have not even seen it on the
netdev list.
Anyway, I don't have it, please resend.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch net-next] xfrm: add missing xfrm message types to selinux perm table
2012-12-05 5:41 ` Steffen Klassert
@ 2012-12-05 6:56 ` Cong Wang
2012-12-05 7:39 ` Steffen Klassert
0 siblings, 1 reply; 6+ messages in thread
From: Cong Wang @ 2012-12-05 6:56 UTC (permalink / raw)
To: Steffen Klassert; +Cc: David Miller, netdev, herbert
On Wed, 2012-12-05 at 06:41 +0100, Steffen Klassert wrote:
> On Tue, Dec 04, 2012 at 01:02:57PM -0500, David Miller wrote:
> > From: Cong Wang <amwang@redhat.com>
> > Date: Tue, 4 Dec 2012 13:39:31 +0800
> >
> > > Cc: Steffen Klassert <steffen.klassert@secunet.com>
> > > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > > Cc: "David S. Miller" <davem@davemloft.net>
> > > Signed-off-by: Cong Wang <amwang@redhat.com>
> >
> > Steffen will you take this into your IPSEC tree?
> >
>
> I would do so, but I have not seen this patch by now.
> Was it really send to me? I have not even seen it on the
> netdev list.
>
> Anyway, I don't have it, please resend.
>
Weird, you are already Cc'ed in the original patch, Cc: Steffen Klassert
<steffen.klassert@secunet.com>.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch net-next] xfrm: add missing xfrm message types to selinux perm table
2012-12-05 6:56 ` Cong Wang
@ 2012-12-05 7:39 ` Steffen Klassert
0 siblings, 0 replies; 6+ messages in thread
From: Steffen Klassert @ 2012-12-05 7:39 UTC (permalink / raw)
To: Cong Wang; +Cc: David Miller, netdev, herbert
On Wed, Dec 05, 2012 at 02:56:25PM +0800, Cong Wang wrote:
> On Wed, 2012-12-05 at 06:41 +0100, Steffen Klassert wrote:
> > On Tue, Dec 04, 2012 at 01:02:57PM -0500, David Miller wrote:
> > > From: Cong Wang <amwang@redhat.com>
> > > Date: Tue, 4 Dec 2012 13:39:31 +0800
> > >
> > > > Cc: Steffen Klassert <steffen.klassert@secunet.com>
> > > > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > > > Cc: "David S. Miller" <davem@davemloft.net>
> > > > Signed-off-by: Cong Wang <amwang@redhat.com>
> > >
> > > Steffen will you take this into your IPSEC tree?
> > >
> >
> > I would do so, but I have not seen this patch by now.
> > Was it really send to me? I have not even seen it on the
> > netdev list.
> >
> > Anyway, I don't have it, please resend.
> >
>
> Weird, you are already Cc'ed in the original patch, Cc: Steffen Klassert
> <steffen.klassert@secunet.com>.
>
Even patchwork does not list this patch, I can only guess that
something went wrong with your submission.
Please resend it,
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Patch net-next] xfrm: add missing xfrm message types to selinux perm table
@ 2012-12-05 7:42 Cong Wang
2012-12-05 8:14 ` Steffen Klassert
0 siblings, 1 reply; 6+ messages in thread
From: Cong Wang @ 2012-12-05 7:42 UTC (permalink / raw)
To: netdev; +Cc: Steffen Klassert, Herbert Xu, David S. Miller, Cong Wang
SElinux perm table is not up-to-date.
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c
index d309e7f..cc191bc 100644
--- a/security/selinux/nlmsgtab.c
+++ b/security/selinux/nlmsgtab.c
@@ -93,6 +93,13 @@ static struct nlmsg_perm nlmsg_xfrm_perms[] =
{ XFRM_MSG_FLUSHPOLICY, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
{ XFRM_MSG_NEWAE, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
{ XFRM_MSG_GETAE, NETLINK_XFRM_SOCKET__NLMSG_READ },
+ { XFRM_MSG_REPORT, NETLINK_XFRM_SOCKET__NLMSG_READ },
+ { XFRM_MSG_MIGRATE, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
+ { XFRM_MSG_NEWSADINFO, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
+ { XFRM_MSG_GETSADINFO, NETLINK_XFRM_SOCKET__NLMSG_READ },
+ { XFRM_MSG_NEWSPDINFO, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
+ { XFRM_MSG_GETSPDINFO, NETLINK_XFRM_SOCKET__NLMSG_READ },
+ { XFRM_MSG_MAPPING, NETLINK_XFRM_SOCKET__NLMSG_READ },
};
static struct nlmsg_perm nlmsg_audit_perms[] =
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Patch net-next] xfrm: add missing xfrm message types to selinux perm table
2012-12-05 7:42 Cong Wang
@ 2012-12-05 8:14 ` Steffen Klassert
0 siblings, 0 replies; 6+ messages in thread
From: Steffen Klassert @ 2012-12-05 8:14 UTC (permalink / raw)
To: Cong Wang
Cc: netdev, Herbert Xu, David S. Miller, Eric Paris,
linux-security-module
Ccing Eric Paris and linux-security-module.
On Wed, Dec 05, 2012 at 03:42:48PM +0800, Cong Wang wrote:
> SElinux perm table is not up-to-date.
>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
>
> ---
> diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c
> index d309e7f..cc191bc 100644
> --- a/security/selinux/nlmsgtab.c
> +++ b/security/selinux/nlmsgtab.c
> @@ -93,6 +93,13 @@ static struct nlmsg_perm nlmsg_xfrm_perms[] =
> { XFRM_MSG_FLUSHPOLICY, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> { XFRM_MSG_NEWAE, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> { XFRM_MSG_GETAE, NETLINK_XFRM_SOCKET__NLMSG_READ },
> + { XFRM_MSG_REPORT, NETLINK_XFRM_SOCKET__NLMSG_READ },
> + { XFRM_MSG_MIGRATE, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> + { XFRM_MSG_NEWSADINFO, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> + { XFRM_MSG_GETSADINFO, NETLINK_XFRM_SOCKET__NLMSG_READ },
> + { XFRM_MSG_NEWSPDINFO, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> + { XFRM_MSG_GETSPDINFO, NETLINK_XFRM_SOCKET__NLMSG_READ },
> + { XFRM_MSG_MAPPING, NETLINK_XFRM_SOCKET__NLMSG_READ },
> };
>
> static struct nlmsg_perm nlmsg_audit_perms[] =
I'm not the maintainer of the file which this patch changes,
but I could take it into the ipsec-next tree if the selinux
people are fine with that.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-05 8:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1354599571-6181-1-git-send-email-amwang@redhat.com>
2012-12-04 18:02 ` [Patch net-next] xfrm: add missing xfrm message types to selinux perm table David Miller
2012-12-05 5:41 ` Steffen Klassert
2012-12-05 6:56 ` Cong Wang
2012-12-05 7:39 ` Steffen Klassert
2012-12-05 7:42 Cong Wang
2012-12-05 8:14 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).