* [PATCH] 3com: make 3c59x depend on HAS_IOPORT
@ 2012-12-05 14:04 Jan Glauber
2012-12-05 17:58 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Jan Glauber @ 2012-12-05 14:04 UTC (permalink / raw)
To: netdev
From: Jan Glauber <jang@linux.vnet.ibm.com>
The 3com driver for 3c59x requires ioport_map. Since not all
architectures support IO port mapping make 3c59x dependent on HAS_IOPORT.
Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>
---
drivers/net/ethernet/3com/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/3com/Kconfig b/drivers/net/ethernet/3com/Kconfig
index bad4fa6..eb56174 100644
--- a/drivers/net/ethernet/3com/Kconfig
+++ b/drivers/net/ethernet/3com/Kconfig
@@ -80,7 +80,7 @@ config PCMCIA_3C589
config VORTEX
tristate "3c590/3c900 series (592/595/597) \"Vortex/Boomerang\" support"
- depends on (PCI || EISA)
+ depends on (PCI || EISA) && HAS_IOPORT
select NET_CORE
select MII
---help---
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] 3com: make 3c59x depend on HAS_IOPORT
2012-12-05 14:04 [PATCH] 3com: make 3c59x depend on HAS_IOPORT Jan Glauber
@ 2012-12-05 17:58 ` David Miller
2012-12-05 19:44 ` Jan Glauber
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2012-12-05 17:58 UTC (permalink / raw)
To: jang; +Cc: netdev
From: Jan Glauber <jang@linux.vnet.ibm.com>
Date: Wed, 05 Dec 2012 15:04:40 +0100
> From: Jan Glauber <jang@linux.vnet.ibm.com>
>
> The 3com driver for 3c59x requires ioport_map. Since not all
> architectures support IO port mapping make 3c59x dependent on HAS_IOPORT.
>
> Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>
Which platforms support PCI or EISA yet do not set HAS_IOPORT?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 3com: make 3c59x depend on HAS_IOPORT
2012-12-05 17:58 ` David Miller
@ 2012-12-05 19:44 ` Jan Glauber
2012-12-05 20:22 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Jan Glauber @ 2012-12-05 19:44 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Wed, 2012-12-05 at 12:58 -0500, David Miller wrote:
> From: Jan Glauber <jang@linux.vnet.ibm.com>
> Date: Wed, 05 Dec 2012 15:04:40 +0100
>
> > From: Jan Glauber <jang@linux.vnet.ibm.com>
> >
> > The 3com driver for 3c59x requires ioport_map. Since not all
> > architectures support IO port mapping make 3c59x dependent on HAS_IOPORT.
> >
> > Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>
>
> Which platforms support PCI or EISA yet do not set HAS_IOPORT?
>
s390. We wont get support for port I/O in the PCI hardware/firmware
layer. (The patches for PCI on s390 are currently in linux-next).
--Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 3com: make 3c59x depend on HAS_IOPORT
2012-12-05 19:44 ` Jan Glauber
@ 2012-12-05 20:22 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-12-05 20:22 UTC (permalink / raw)
To: jang; +Cc: netdev
From: Jan Glauber <jang@linux.vnet.ibm.com>
Date: Wed, 05 Dec 2012 20:44:26 +0100
> On Wed, 2012-12-05 at 12:58 -0500, David Miller wrote:
>> From: Jan Glauber <jang@linux.vnet.ibm.com>
>> Date: Wed, 05 Dec 2012 15:04:40 +0100
>>
>> > From: Jan Glauber <jang@linux.vnet.ibm.com>
>> >
>> > The 3com driver for 3c59x requires ioport_map. Since not all
>> > architectures support IO port mapping make 3c59x dependent on HAS_IOPORT.
>> >
>> > Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>
>>
>> Which platforms support PCI or EISA yet do not set HAS_IOPORT?
>>
>
> s390. We wont get support for port I/O in the PCI hardware/firmware
> layer. (The patches for PCI on s390 are currently in linux-next).
Ok, I'll apply this to net-next, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-05 20:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05 14:04 [PATCH] 3com: make 3c59x depend on HAS_IOPORT Jan Glauber
2012-12-05 17:58 ` David Miller
2012-12-05 19:44 ` Jan Glauber
2012-12-05 20:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).