From: David Woodhouse <dwmw2@infradead.org>
To: John Greene <jogreene@redhat.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [RFT PATCH] 8139cp: properly support change of MTU values [v2]
Date: Thu, 06 Dec 2012 01:34:18 +0000 [thread overview]
Message-ID: <1354757658.24281.234.camel@shinybook.infradead.org> (raw)
In-Reply-To: <50BE4924.40904@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Tue, 2012-12-04 at 14:04 -0500, John Greene wrote:
> Still, this does fix reported problem that driver could be set to huge
> MTU erroneously, and now rejects really weird values as it should.
Yes, absolutely. As long as the caveat is understood, feel free to add
Tested-by: David Woodhouse <David.Woodhouse@intel.com>
I did look through the datasheet to see if there's anything we can do to
improve reception of large packets. We could try to reduce the Rx Fifo
threshold, which we currently set at 512 bytes... but it isn't going to
get us much further on this particular hardware. Might be nice to have
it tunable though.
There's a v1.6 datasheet at http://realtek.info/pdf/rtl8139cp.pdf btw.
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]
next prev parent reply other threads:[~2012-12-06 1:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 16:19 [RFT PATCH] 8139cp: properly support change of MTU values [v2] John Greene
2012-12-03 18:52 ` David Miller
2012-12-03 20:46 ` Francois Romieu
2012-12-04 15:44 ` David Woodhouse
2012-12-04 19:04 ` John Greene
2012-12-06 1:34 ` David Woodhouse [this message]
2012-12-05 19:41 ` John Greene
2012-12-13 19:56 ` John Greene
2012-12-13 22:36 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354757658.24281.234.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).