netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joseph Gasparakis <joseph.gasparakis@intel.com>
To: davem@davemloft.net, shemminger@vyatta.com, chrisw@sous-sol.org,
	gospo@redhat.com
Cc: Joseph Gasparakis <joseph.gasparakis@intel.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmitry@broadcom.com, saeed.bishara@gmail.com
Subject: [PATCH v3 net-next 0/4] tunneling: Add support for hardware-offloaded encapsulation
Date: Thu,  6 Dec 2012 17:56:55 -0800	[thread overview]
Message-ID: <1354845419-22483-1-git-send-email-joseph.gasparakis@intel.com> (raw)

The series contains updates to add in the NIC Rx and Tx checksumming support
for encapsulated packets.

The sk_buff needs to somehow have information of the inner packet, and adding
three fields for the inner mac, network and transport headers was the prefered
approach. 

Not adding these fields would mean that the drivers would need to parse the
sk_buff data in hot-path, having a negative impact in the performance.

Adding in sk_buff a pointer to the skbuff of the inner packet made sense, but
would be a complicated change as assumptions needed to be made with regards to
helper functions such as skb_clone() skb_copy(). Also code for the existing
encapsulation protocols (such as VXLAN and IP GRE) had to be reworked, so the
decision was to have the simple approach of adding these three fields.

v2 Makes sure that checksumming for IP GRE does not take place if the offload
   flag is set in the skb's netdev features

v3 Fixes issues picked up by the community in v2 and is intended to provide
   ability to demo vxlan Tx offloading with Intel's ixgbe. As part of this, 
   it provides an RFC patch for ixgbe to take advantage of the offloading
   mechanism

   Now it is possible to create a vxlan interface like this:
    #ip link add vxlan0 type vxlan id 40 ttl 10 group 239.1.1.1 dev eth0

   Then turn on/off the encapsulation offload mechanism by doing:
    #ethtool -K eth0 tx-checksum-ip-generic on

   In v3 ipgre work got paused (and therefore patches not included) and I will
   come back to it when vxlan is accepted by the community.

             reply	other threads:[~2012-12-07  1:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07  1:56 Joseph Gasparakis [this message]
2012-12-07  1:56 ` [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation Joseph Gasparakis
2012-12-07 10:07   ` Ben Hutchings
2012-12-07 16:45     ` Alexander Duyck
2012-12-07 17:13       ` Ben Hutchings
2012-12-07 18:24         ` Joseph Gasparakis
2012-12-07 19:28           ` David Miller
2012-12-07 19:41             ` Joseph Gasparakis
2012-12-07 19:37               ` David Miller
2012-12-07 19:52                 ` Joseph Gasparakis
2012-12-07 19:52                   ` David Miller
2012-12-07 20:18                     ` Joseph Gasparakis
2012-12-07 23:15   ` Jeff Kirsher
2012-12-07  1:56 ` [PATCH v3 2/4] net: Handle encapsulated offloads before fragmentation or handing to lower dev Joseph Gasparakis
2012-12-07 23:15   ` Jeff Kirsher
2012-12-07  1:56 ` [PATCH v3 3/4] vxlan: capture inner headers during encapsulation Joseph Gasparakis
2012-12-07 23:16   ` Jeff Kirsher
2012-12-07  1:56 ` [RFC PATCH v3 4/4] ixgbe: Adding tx encapsulation capability Joseph Gasparakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354845419-22483-1-git-send-email-joseph.gasparakis@intel.com \
    --to=joseph.gasparakis@intel.com \
    --cc=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=dmitry@broadcom.com \
    --cc=gospo@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeed.bishara@gmail.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).