From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [RFC V3 1/2] I'dcfg80211: Move the definition of struct mac_address up Date: Thu, 06 Dec 2012 21:38:55 -0800 Message-ID: <1354858735.22463.31.camel@joe-AO722> References: <1354853850-10537-1-git-send-email-vthiagar@qca.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev To: Vasanthakumar Thiagarajan Return-path: In-Reply-To: <1354853850-10537-1-git-send-email-vthiagar-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, 2012-12-07 at 09:47 +0530, Vasanthakumar Thiagarajan wrote: > struct mac_address will be used by ACL related configuration ops. I'd prefer that any new code _not_ use struct mac_address but use u8 addr[ETH_ALEN] instead. That's the most common style in the kernel. $ git grep -E "\bu8\s+\w+\s*\[\s*ETH_ALEN\s*\]" | wc -l 749 $ git grep -E "\bstruct\s+mac_address\b" | wc -l 13 There are also uses of char and unsigned char $ git grep -E "\bchar\s+\w+\s*\[\s*ETH_ALEN\s*\]" | wc -l 121 Some of those are ancient, but it'd be good to be consistent throughout the kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html