* Re: [RFC V3 1/2] I'dcfg80211: Move the definition of struct mac_address up
[not found] ` <1354853850-10537-1-git-send-email-vthiagar-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>
@ 2012-12-07 5:38 ` Joe Perches
2012-12-07 6:56 ` Vasanthakumar Thiagarajan
2012-12-07 8:09 ` Johannes Berg
0 siblings, 2 replies; 3+ messages in thread
From: Joe Perches @ 2012-12-07 5:38 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan
Cc: linville-2XuSBdqkA4R54TAoqtyWWQ, johannes-cdvu00un1VgdHxzADdlk8Q,
linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev
On Fri, 2012-12-07 at 09:47 +0530, Vasanthakumar Thiagarajan wrote:
> struct mac_address will be used by ACL related configuration ops.
I'd prefer that any new code _not_ use struct mac_address
but use u8 addr[ETH_ALEN] instead.
That's the most common style in the kernel.
$ git grep -E "\bu8\s+\w+\s*\[\s*ETH_ALEN\s*\]" | wc -l
749
$ git grep -E "\bstruct\s+mac_address\b" | wc -l
13
There are also uses of char and unsigned char
$ git grep -E "\bchar\s+\w+\s*\[\s*ETH_ALEN\s*\]" | wc -l
121
Some of those are ancient, but it'd be good to
be consistent throughout the kernel.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFC V3 1/2] I'dcfg80211: Move the definition of struct mac_address up
2012-12-07 5:38 ` [RFC V3 1/2] I'dcfg80211: Move the definition of struct mac_address up Joe Perches
@ 2012-12-07 6:56 ` Vasanthakumar Thiagarajan
2012-12-07 8:09 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Vasanthakumar Thiagarajan @ 2012-12-07 6:56 UTC (permalink / raw)
To: Joe Perches
Cc: linville-2XuSBdqkA4R54TAoqtyWWQ, johannes-cdvu00un1VgdHxzADdlk8Q,
linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev
On Friday 07 December 2012 11:08 AM, Joe Perches wrote:
> On Fri, 2012-12-07 at 09:47 +0530, Vasanthakumar Thiagarajan wrote:
>> struct mac_address will be used by ACL related configuration ops.
>
> I'd prefer that any new code _not_ use struct mac_address
> but use u8 addr[ETH_ALEN] instead.
>
> That's the most common style in the kernel.
Ok, but struct mac_address looked handy when I want
to deal with list of mac address instead using linked
list. Thanks!
Vasanth
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC V3 1/2] I'dcfg80211: Move the definition of struct mac_address up
2012-12-07 5:38 ` [RFC V3 1/2] I'dcfg80211: Move the definition of struct mac_address up Joe Perches
2012-12-07 6:56 ` Vasanthakumar Thiagarajan
@ 2012-12-07 8:09 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2012-12-07 8:09 UTC (permalink / raw)
To: Joe Perches; +Cc: Vasanthakumar Thiagarajan, linville, linux-wireless, netdev
On Thu, 2012-12-06 at 21:38 -0800, Joe Perches wrote:
> On Fri, 2012-12-07 at 09:47 +0530, Vasanthakumar Thiagarajan wrote:
> > struct mac_address will be used by ACL related configuration ops.
>
> I'd prefer that any new code _not_ use struct mac_address
> but use u8 addr[ETH_ALEN] instead.
Passing around arrays of that is inconvenient, hence the struct.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-07 8:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1354853850-10537-1-git-send-email-vthiagar@qca.qualcomm.com>
[not found] ` <1354853850-10537-1-git-send-email-vthiagar-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>
2012-12-07 5:38 ` [RFC V3 1/2] I'dcfg80211: Move the definition of struct mac_address up Joe Perches
2012-12-07 6:56 ` Vasanthakumar Thiagarajan
2012-12-07 8:09 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).