From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Tom Herbert <therbert@google.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH] dynamic_queue_limit.h: Make the struct ___cacheline_aligned_on_smp
Date: Fri, 07 Dec 2012 08:29:21 -0800 [thread overview]
Message-ID: <1354897761.29937.45.camel@joe-AO722> (raw)
In-Reply-To: <1354897144.26405.4.camel@edumazet-glaptop>
On Fri, 2012-12-07 at 08:19 -0800, Eric Dumazet wrote:
> On Fri, 2012-12-07 at 08:05 -0800, Joe Perches wrote:
>
> > So it seemed somewhat sensible to make the
> > entire struct in a single cacheline.
>
> Any layout change in an object used in network fast path need a complete
> performance study.
>
> Even if you provide such a study, we'll need to reproduce your numbers
> here.
>
> BQL/DQL is not on our radars, spending two cache lines on a critical
> object is fine.
Well Maybe Tom can provide some information as to why
the limit variable was cacheline_aligned_in_smp and not
the struct.
I didn't find any discussion about it.
next prev parent reply other threads:[~2012-12-07 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 14:58 [RFC PATCH] dynamic_queue_limit.h: Make the struct ___cacheline_aligned_on_smp Joe Perches
2012-12-07 15:55 ` Eric Dumazet
2012-12-07 16:05 ` Joe Perches
2012-12-07 16:19 ` Eric Dumazet
2012-12-07 16:29 ` Joe Perches [this message]
2012-12-07 16:42 ` Ben Hutchings
2012-12-07 16:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354897761.29937.45.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).