netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ssb: use WARN in main.c
@ 2012-12-08 23:11 Cong Ding
  0 siblings, 0 replies; only message in thread
From: Cong Ding @ 2012-12-08 23:11 UTC (permalink / raw)
  To: Michael Buesch, netdev, linux-kernel; +Cc: Cong Ding

Use WARN rather than printk followed by WARN_ON(1), for conciseness.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 drivers/ssb/main.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index bd7115c..c82c5c9 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1133,8 +1133,7 @@ static u32 ssb_tmslow_reject_bitmask(struct ssb_device *dev)
 	case SSB_IDLOW_SSBREV_27:     /* same here */
 		return SSB_TMSLOW_REJECT;	/* this is a guess */
 	default:
-		printk(KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev);
-		WARN_ON(1);
+		WARN(1, KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev);
 	}
 	return (SSB_TMSLOW_REJECT | SSB_TMSLOW_REJECT_23);
 }
-- 
1.7.4.5

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-12-08 23:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-08 23:11 [PATCH] ssb: use WARN in main.c Cong Ding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).